Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 9768007: ChromeOS mixer: Talk to new ChromeOS audio server. (Closed)

Created:
8 years, 9 months ago by Daniel Erat
Modified:
8 years, 9 months ago
Reviewers:
dgreid
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

ChromeOS mixer: Talk to new ChromeOS audio server. Instead of talking to ALSA in dB we talk to the new audio server (CRAS) in percent. CRAS will contain a board-specific volume curve for mapping percent to dB. Change written by Dylan Reid <dgreid@chromium.org>;. BUG=chromium-os:25413 TEST=On lumpy: gmerge chromeos-chrome, run chrome and adjust volume. TBR=dgreid Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127902

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -0 lines) Patch
M chrome/browser/chromeos/audio/audio_handler.cc View 2 chunks +8 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/audio/audio_mixer_cras.h View 1 chunk +72 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/audio/audio_mixer_cras.cc View 1 chunk +147 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Daniel Erat
8 years, 9 months ago (2012-03-21 00:46:46 UTC) #1
dgreid
LGTM, built and ran from the chroot with use_cras defined.
8 years, 9 months ago (2012-03-21 01:11:02 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 9 months ago (2012-03-21 02:35:19 UTC) #3
Daniel Erat
LGTM (Not sure if it'll work, but self-LGTM-ing. This is Dylan's change and I already ...
8 years, 9 months ago (2012-03-21 02:38:52 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 9 months ago (2012-03-21 02:39:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/9768007/1
8 years, 9 months ago (2012-03-21 02:40:32 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-21 04:24:14 UTC) #7
Change committed as 127902

Powered by Google App Engine
This is Rietveld 408576698