Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 976723002: Add support for postNonNestableIdleTask to the Scheduler and use it in Oilpan (Closed)

Created:
5 years, 9 months ago by rmcilroy
Modified:
5 years, 9 months ago
CC:
Mads Ager (chromium), blink-reviews, dglazkov+blink, haraken, kouhei+heap_chromium.org, oilpan-reviews, scheduler-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add support for postNonNestableIdleTask to the Scheduler and use it in Oilpan Adds postNonNestableIdleTask functionality to the Scheduler and modifies Oilpan's idle GC task to be posted as non-nestable idle tasks. This guarantees that there will be no heap pointers on the stack when Oilpan's idle GC task is run and enables the GC to be precise instead of conservative. Chromium side of patch: https://codereview.chromium.org/970473004/ BUG=455713 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191906

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M Source/platform/heap/ThreadState.cpp View 1 2 chunks +2 lines, -3 lines 0 comments Download
M Source/platform/scheduler/Scheduler.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M Source/platform/scheduler/Scheduler.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download
M public/platform/WebScheduler.h View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
rmcilroy
haraken / kouhei@: Could you please take a look at the Oilpan change. skyostil@: Could ...
5 years, 9 months ago (2015-03-03 19:34:59 UTC) #2
haraken
LGTM Do you know a way to check that we're not in a nested event ...
5 years, 9 months ago (2015-03-04 01:15:09 UTC) #3
kouhei (in TOK)
Yay! Thanks for adding support for this. lgtm
5 years, 9 months ago (2015-03-04 01:15:21 UTC) #4
Sami
lgtm, thanks Ross! On 2015/03/04 01:15:09, haraken wrote: > Do you know a way to ...
5 years, 9 months ago (2015-03-04 11:01:01 UTC) #5
rmcilroy
On 2015/03/04 01:15:09, haraken wrote: > LGTM > > Do you know a way to ...
5 years, 9 months ago (2015-03-13 22:51:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/976723002/1
5 years, 9 months ago (2015-03-13 22:51:55 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_blink_compile_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_rel/builds/31443)
5 years, 9 months ago (2015-03-13 22:57:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/976723002/20001
5 years, 9 months ago (2015-03-16 09:33:38 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/29029)
5 years, 9 months ago (2015-03-16 09:50:28 UTC) #15
rmcilroy
jochen@chromium.org: Please review changes in public/platform/WebScheduler.h, thanks!
5 years, 9 months ago (2015-03-16 10:46:53 UTC) #17
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-16 10:48:27 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/976723002/20001
5 years, 9 months ago (2015-03-16 10:49:37 UTC) #20
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 11:09:02 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191906

Powered by Google App Engine
This is Rietveld 408576698