Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1499)

Unified Diff: Source/platform/heap/ThreadState.cpp

Issue 976723002: Add support for postNonNestableIdleTask to the Scheduler and use it in Oilpan (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/platform/scheduler/Scheduler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/heap/ThreadState.cpp
diff --git a/Source/platform/heap/ThreadState.cpp b/Source/platform/heap/ThreadState.cpp
index 78dbd72ebbbb69142a7e5922dbb6e00826598b5b..728bb222dca5663de9563db0a6c58cad681ee482 100644
--- a/Source/platform/heap/ThreadState.cpp
+++ b/Source/platform/heap/ThreadState.cpp
@@ -596,8 +596,7 @@ void ThreadState::performIdleGC(double deadlineSeconds)
return;
}
- // FIXME: Make this precise once idle task is guaranteed to be not in nested loop.
- Heap::collectGarbage(HeapPointersOnStack, GCWithoutSweep, Heap::IdleGC);
+ Heap::collectGarbage(NoHeapPointersOnStack, GCWithoutSweep, Heap::IdleGC);
}
void ThreadState::scheduleIdleGC()
@@ -612,7 +611,7 @@ void ThreadState::scheduleIdleGC()
if (!m_hasPendingIdleTask) {
m_hasPendingIdleTask = true;
- Scheduler::shared()->postIdleTask(FROM_HERE, WTF::bind<double>(&ThreadState::performIdleGC, this));
+ Scheduler::shared()->postNonNestableIdleTask(FROM_HERE, WTF::bind<double>(&ThreadState::performIdleGC, this));
}
setGCState(IdleGCScheduled);
}
« no previous file with comments | « no previous file | Source/platform/scheduler/Scheduler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698