LayoutTests/http/tests/htmlimports/import-cors-credentials.html - Issue 976263002: HTML Imports: Teach preloader about HTML Imports.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/htmlimports/import-cors-credentials.html

Issue 976263002: HTML Imports: Teach preloader about HTML Imports. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: update Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/http/tests/htmlimports/import-cors-credentials.html

diff --git a/LayoutTests/http/tests/htmlimports/import-cors-credentials.html b/LayoutTests/http/tests/htmlimports/import-cors-credentials.html

index beb90273443369e7392ef3ebcf3ac77ddd1d5dae..bba700a1a8b9b12154961d73aaa532b76f552e84 100644

--- a/LayoutTests/http/tests/htmlimports/import-cors-credentials.html

+++ b/LayoutTests/http/tests/htmlimports/import-cors-credentials.html

@@ -1,18 +1,10 @@

<!DOCTYPE html>

-<script src="/js-test-resources/js-test.js"></script>

-document.cookie = "key=HelloCredentials";

-</script>

-<link id="sameOrigin" rel="import" href="resources/cookie-match.cgi?key=HelloCredentials">

-<link id="crossOrigin" rel="import" href="http://localhost:8080/htmlimports/resources/cookie-match.cgi">

-<link id="fromSameToCrossOrigin" rel="import" href="resources/having-cookie-match-8080.html">

-<link id="fromCrossToSameOrigin" rel="import" href="http://localhost:8080/htmlimports/resources/having-cookie-match-same.cgi">

-<script>

-if (window.testRunner)

+if (window.testRunner) {

testRunner.dumpAsText();

+ testRunner.waitUntilDone();

-shouldBeEqualToString("sameOrigin.import.body.innerHTML", "PASS");

-shouldBeEqualToString("crossOrigin.import.body.innerHTML", "PASS");

-shouldBeEqualToString("fromSameToCrossOrigin.import.getElementById('crossOrigin').import.body.innerHTML", "PASS");

-shouldBeEqualToString("fromCrossToSameOrigin.import.getElementById('sameOrigin').import.body.innerHTML", "PASS");

+document.cookie = "key=HelloCredentials";

+window.location = "resources/import-cors-credentials-body.html";

Yoav Weiss 2015/06/09 07:53:40 Why is this change related to the code change?

yoichio 2015/06/11 04:27:43 Because we preload not waiting this script inserti

Yoav Weiss 2015/06/11 10:50:47 OK, great :)

</script>