LayoutTests/http/tests/htmlimports/import-cors-credentials.html - Issue 976263002: HTML Imports: Teach preloader about HTML Imports.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/htmlimports/import-cors-credentials.html

Issue 976263002: HTML Imports: Teach preloader about HTML Imports. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: update Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/http/tests/htmlimports/import-async.html ('k') | LayoutTests/http/tests/htmlimports/import-preload.html » ('j') | LayoutTests/http/tests/htmlimports/import-preload.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="/js-test-resources/js-test.js"></script>

3 <script>	2 <script>

	3 if (window.testRunner) {

	4 testRunner.dumpAsText();

	5 testRunner.waitUntilDone();

	6 }

	7

4 document.cookie = "key=HelloCredentials";	8 document.cookie = "key=HelloCredentials";

	9 window.location = "resources/import-cors-credentials-body.html";
	Yoav Weiss 2015/06/09 07:53:40 Why is this change related to the code change? Why is this change related to the code change? yoichio 2015/06/11 04:27:43 Because we preload not waiting this script inserti Show quoted text On 2015/06/09 07:53:40, Yoav Weiss wrote: > Why is this change related to the code change? Because we preload not waiting this script inserting cookie so tests fail. Yoav Weiss 2015/06/11 10:50:47 OK, great :) Show quoted text On 2015/06/11 04:27:43, yoichio wrote: > On 2015/06/09 07:53:40, Yoav Weiss wrote: > > Why is this change related to the code change? > > Because we preload not waiting this script inserting cookie so tests fail. OK, great :)
5 </script>	10 </script>

6 <link id="sameOrigin" rel="import" href="resources/cookie-match.cgi?key=HelloCre dentials">

7 <link id="crossOrigin" rel="import" href="http://localhost:8080/htmlimports/reso urces/cookie-match.cgi">

8 <link id="fromSameToCrossOrigin" rel="import" href="resources/having-cookie-matc h-8080.html">

9 <link id="fromCrossToSameOrigin" rel="import" href="http://localhost:8080/htmlim ports/resources/having-cookie-match-same.cgi">

10 <script>

11 if (window.testRunner)

12 testRunner.dumpAsText();

13

14 shouldBeEqualToString("sameOrigin.import.body.innerHTML", "PASS");

15 shouldBeEqualToString("crossOrigin.import.body.innerHTML", "PASS");

16 shouldBeEqualToString("fromSameToCrossOrigin.import.getElementById('crossOrigin' ).import.body.innerHTML", "PASS");

17 shouldBeEqualToString("fromCrossToSameOrigin.import.getElementById('sameOrigin') .import.body.innerHTML", "PASS");

18 </script>

OLD	NEW