Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 976163002: [Win, Android] Don't create WebSandboxSupport when it would have no methods. (Closed)

Created:
5 years, 9 months ago by jbroman
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Win, Android] Don't create WebSandboxSupport when it would have no methods. This removes includes of android/ and win/WebSandboxSupport.h, and only has the platform implementations create it on the platforms that do have a WebSandboxSupport (Mac, Linux). If this lands, the empty WebSandboxSupport headers can be removed from Blink in a followup CL. BUG=463506 Committed: https://crrev.com/bae266e499db1170ec00e13ab08f4c3b6b235ec8 Cr-Commit-Position: refs/heads/master@{#319653}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -59 lines) Patch
M content/ppapi_plugin/ppapi_blink_platform_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/ppapi_plugin/ppapi_blink_platform_impl.cc View 6 chunks +18 lines, -30 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 7 chunks +9 lines, -29 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
jbroman
Since you expressed a desire to remove "empty" WebSandboxSupport, here's the Chromium-side CL which would ...
5 years, 9 months ago (2015-03-05 15:08:54 UTC) #2
eae
Seems like a step in the right direction to me, thanks for doing this. non-owner ...
5 years, 9 months ago (2015-03-05 19:12:57 UTC) #3
eae
Seems like a step in the right direction to me, thanks for doing this. non-owner ...
5 years, 9 months ago (2015-03-05 19:12:57 UTC) #4
Mike West
I think this is an improvement, but I get what you mean about the additional ...
5 years, 9 months ago (2015-03-06 02:51:24 UTC) #5
jbroman
+jochen for content/ OWNERS
5 years, 9 months ago (2015-03-06 02:53:32 UTC) #7
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-09 15:29:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/976163002/1
5 years, 9 months ago (2015-03-09 15:37:25 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 16:53:08 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 16:53:57 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bae266e499db1170ec00e13ab08f4c3b6b235ec8
Cr-Commit-Position: refs/heads/master@{#319653}

Powered by Google App Engine
This is Rietveld 408576698