[Win, Android] Don't create WebSandboxSupport when it would have no methods.

content/ppapi_plugin/ppapi_blink_platform_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/ppapi_plugin/ppapi_blink_platform_impl.h"
 
 #include <map>
 
 #include "base/logging.h"
 #include "base/strings/string16.h"
 #include "base/threading/platform_thread.h"
 #include "build/build_config.h"
 #include "content/child/child_thread_impl.h"
 #include "content/common/child_process_messages.h"
 #include "ppapi/proxy/plugin_globals.h"
 #include "ppapi/shared_impl/proxy_lock.h"
 #include "third_party/WebKit/public/platform/WebString.h"
 
-#if defined(OS_WIN)
-#include "third_party/WebKit/public/platform/win/WebSandboxSupport.h"
-#elif defined(OS_MACOSX)
+#if defined(OS_MACOSX)
 #include "third_party/WebKit/public/platform/mac/WebSandboxSupport.h"
-#elif defined(OS_ANDROID)
-#include "third_party/WebKit/public/platform/android/WebSandboxSupport.h"
-#elif defined(OS_POSIX)
+#elif defined(OS_POSIX) && !defined(OS_ANDROID)
 #include "content/common/child_process_sandbox_support_impl_linux.h"
 #include "third_party/WebKit/public/platform/linux/WebFallbackFont.h"
 #include "third_party/WebKit/public/platform/linux/WebSandboxSupport.h"
 #include "third_party/icu/source/common/unicode/utf16.h"
 #endif
 
 using blink::WebSandboxSupport;
 using blink::WebString;
 using blink::WebUChar;
 using blink::WebUChar32;
 
 typedef struct CGFont* CGFontRef;
 
 namespace content {
 
+#if !defined(OS_ANDROID) && !defined(OS_WIN)
+
 class PpapiBlinkPlatformImpl::SandboxSupport : public WebSandboxSupport {
  public:
   virtual ~SandboxSupport() {}
 
-#if defined(OS_WIN)
-  virtual bool ensureFontLoaded(HFONT);
-#elif defined(OS_MACOSX)
+#if defined(OS_MACOSX)
   virtual bool loadFont(NSFont* srcFont, CGFontRef* out, uint32_t* fontID);
-#elif defined(OS_ANDROID)
-  // Empty class.
 #elif defined(OS_POSIX)
   SandboxSupport();
   virtual void getFallbackFontForCharacter(
       WebUChar32 character,
       const char* preferred_locale,
       blink::WebFallbackFont* fallbackFont);
   virtual void getRenderStyleForStrike(const char* family,
                                        int sizeAndStyle,
                                        blink::WebFontRenderStyle* out);
 
  private:
   // WebKit likes to ask us for the correct font family to use for a set of
   // unicode code points. It needs this information frequently so we cache it
   // here.
   std::map<int32_t, blink::WebFallbackFont> unicode_font_families_;
   // For debugging crbug.com/312965
   base::PlatformThreadId creation_thread_;
 #endif
 };
 
-#if defined(OS_WIN)
-
-bool PpapiBlinkPlatformImpl::SandboxSupport::ensureFontLoaded(HFONT font) {
-  LOGFONT logfont;
-  GetObject(font, sizeof(LOGFONT), &logfont);
-
-  // Use the proxy sender rather than going directly to the ChildThread since
-  // the proxy browser sender will properly unlock during sync messages.
-  return ppapi::proxy::PluginGlobals::Get()->GetBrowserSender()->Send(
-      new ChildProcessHostMsg_PreCacheFont(logfont));
-}
-
-#elif defined(OS_MACOSX)
+#if defined(OS_MACOSX)
 
 bool PpapiBlinkPlatformImpl::SandboxSupport::loadFont(NSFont* src_font,
                                                       CGFontRef* out,
                                                       uint32_t* font_id) {
   // TODO(brettw) this should do the something similar to what
   // RendererBlinkPlatformImpl does and request that the browser load the font.
   // Note: need to unlock the proxy lock like ensureFontLoaded does.
   NOTIMPLEMENTED();
   return false;
 }
 
-#elif defined(OS_ANDROID)
-
-// Empty class.
-
 #elif defined(OS_POSIX)
 
 PpapiBlinkPlatformImpl::SandboxSupport::SandboxSupport()
     : creation_thread_(base::PlatformThread::CurrentId()) {
 }
 
 void PpapiBlinkPlatformImpl::SandboxSupport::getFallbackFontForCharacter(
     WebUChar32 character,
     const char* preferred_locale,
     blink::WebFallbackFont* fallbackFont) {
@@ skipping 18 matching lines @@
 
 void PpapiBlinkPlatformImpl::SandboxSupport::getRenderStyleForStrike(
     const char* family,
     int sizeAndStyle,
     blink::WebFontRenderStyle* out) {
   GetRenderStyleForStrike(family, sizeAndStyle, out);
 }
 
 #endif
 
-PpapiBlinkPlatformImpl::PpapiBlinkPlatformImpl()
-    : sandbox_support_(new PpapiBlinkPlatformImpl::SandboxSupport()) {
+#endif  // !defined(OS_ANDROID) && !defined(OS_WIN)
+
+PpapiBlinkPlatformImpl::PpapiBlinkPlatformImpl() {
+#if !defined(OS_ANDROID) && !defined(OS_WIN)
+  sandbox_support_.reset(new PpapiBlinkPlatformImpl::SandboxSupport);
+#endif
 }
 
 PpapiBlinkPlatformImpl::~PpapiBlinkPlatformImpl() {
 }
 
 void PpapiBlinkPlatformImpl::Shutdown() {
+#if !defined(OS_ANDROID) && !defined(OS_WIN)
   // SandboxSupport contains a map of WebFontFamily objects, which hold
   // WebCStrings, which become invalidated when blink is shut down. Hence, we
   // need to clear that map now, just before blink::shutdown() is called.
   sandbox_support_.reset();
+#endif
 }
 
 blink::WebClipboard* PpapiBlinkPlatformImpl::clipboard() {
   NOTREACHED();
   return NULL;
 }
 
 blink::WebMimeRegistry* PpapiBlinkPlatformImpl::mimeRegistry() {
   NOTREACHED();
   return NULL;
 }
 
 blink::WebFileUtilities* PpapiBlinkPlatformImpl::fileUtilities() {
   NOTREACHED();
   return NULL;
 }
 
 blink::WebSandboxSupport* PpapiBlinkPlatformImpl::sandboxSupport() {
+#if !defined(OS_ANDROID) && !defined(OS_WIN)
   return sandbox_support_.get();
+#else
+  return nullptr;
+#endif
 }
 
 bool PpapiBlinkPlatformImpl::sandboxEnabled() {
   return true;  // Assume PPAPI is always sandboxed.
 }
 
 unsigned long long PpapiBlinkPlatformImpl::visitedLinkHash(
     const char* canonical_url,
     size_t length) {
   NOTREACHED();
@@ skipping 70 matching lines @@
 }
 
 int PpapiBlinkPlatformImpl::databaseDeleteFile(
     const blink::WebString& vfs_file_name,
     bool sync_dir) {
   NOTREACHED();
   return 0;
 }
 
 }  // namespace content