Issue 976013002: Miscellaneous fixes for MSVC.

Issue 976013002: Miscellaneous fixes for MSVC. (Closed)

Created:
5 years, 9 months ago by Ken Rockot(use gerrit already)

Modified:
5 years, 9 months ago

Reviewers:
viettrungluu

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Miscellaneous fixes for MSVC. BUG=None R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f8d8c7ede50bae8ee83539b377a49929bb7e93a9

Patch Set 2 : TODO #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	mojo/edk/system/remote_producer_data_pipe_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	mojo/public/cpp/bindings/binding.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ken Rockot(use gerrit already)

Trung, please take a look. These changes are also applied to this a pending mojo->chrome ...

5 years, 9 months ago (2015-03-04 01:34:34 UTC) #1

viettrungluu

LGTM w/request for a TODO. https://codereview.chromium.org/976013002/diff/1/mojo/public/cpp/bindings/binding.h File mojo/public/cpp/bindings/binding.h (right): https://codereview.chromium.org/976013002/diff/1/mojo/public/cpp/bindings/binding.h#newcode172 mojo/public/cpp/bindings/binding.h:172: return request.Pass(); Could you ...

5 years, 9 months ago (2015-03-04 02:17:57 UTC) #2

Ken Rockot(use gerrit already)

https://codereview.chromium.org/976013002/diff/1/mojo/public/cpp/bindings/binding.h File mojo/public/cpp/bindings/binding.h (right): https://codereview.chromium.org/976013002/diff/1/mojo/public/cpp/bindings/binding.h#newcode172 mojo/public/cpp/bindings/binding.h:172: return request.Pass(); On 2015/03/04 02:17:57, viettrungluu wrote: > Could ...

5 years, 9 months ago (2015-03-04 03:02:13 UTC) #3

Ken Rockot(use gerrit already)

5 years, 9 months ago (2015-03-04 03:02:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
f8d8c7ede50bae8ee83539b377a49929bb7e93a9 (presubmit successful).

Expand Messages | Collapse Messages