mojo/public/cpp/bindings/binding.h - Issue 976013002: Miscellaneous fixes for MSVC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/binding.h

Issue 976013002: Miscellaneous fixes for MSVC. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: TODO Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/bindings/binding.h

diff --git a/mojo/public/cpp/bindings/binding.h b/mojo/public/cpp/bindings/binding.h

index 188ac6e82ce4659360bb5bb838deafbcf779ac13..f178431c3f9d5731d669c390c468946cb2bf71a6 100644

--- a/mojo/public/cpp/bindings/binding.h

+++ b/mojo/public/cpp/bindings/binding.h

@@ -169,7 +169,9 @@ class Binding : public ErrorHandler {

InterfaceRequest<Interface> request =

MakeRequest<Interface>(internal_router_->PassMessagePipe());

DestroyRouter();

- return request;

+ // TODO(vtl): The |.Pass()| below is only needed due to an MSVS bug; remove

+ // it once that's fixed.

+ return request.Pass();

}

// Sets an error handler that will be called if a connection error occurs on

« no previous file with comments | « mojo/edk/system/remote_producer_data_pipe_impl.cc ('k') | no next file » | no next file with comments »