Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 975963003: Address NewApi warning in device/battery. (Closed)

Created:
5 years, 9 months ago by newt (away)
Modified:
5 years, 9 months ago
Reviewers:
timvolodine
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, timvolodine, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Address NewApi warning in device/battery. This moves the Lollipop-specific code in BatteryStatusManager into a separate method and annotates it with @TargetApi(LOLLIPOP) so appease Android lint. BUG=411461 Committed: https://crrev.com/ad10b9efa0237699081d15c931ecf26820460c16 Cr-Commit-Position: refs/heads/master@{#319115}

Patch Set 1 #

Total comments: 2

Patch Set 2 : added assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -25 lines) Patch
M build/android/lint/suppressions.xml View 1 chunk +0 lines, -1 line 0 comments Download
M device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java View 1 2 chunks +34 lines, -24 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
newt (away)
PTAL
5 years, 9 months ago (2015-03-04 02:47:05 UTC) #2
timvolodine
thanks! lgtm. https://codereview.chromium.org/975963003/diff/1/device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java File device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java (right): https://codereview.chromium.org/975963003/diff/1/device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java#newcode151 device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java:151: private void updateBatteryStatusForLollipop(BatteryStatus batteryStatus) { nit: maybe ...
5 years, 9 months ago (2015-03-04 11:26:09 UTC) #3
newt (away)
https://codereview.chromium.org/975963003/diff/1/device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java File device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java (right): https://codereview.chromium.org/975963003/diff/1/device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java#newcode151 device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java:151: private void updateBatteryStatusForLollipop(BatteryStatus batteryStatus) { On 2015/03/04 11:26:09, timvolodine ...
5 years, 9 months ago (2015-03-04 19:12:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/975963003/20001
5 years, 9 months ago (2015-03-04 19:14:53 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-04 20:13:19 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 20:13:44 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ad10b9efa0237699081d15c931ecf26820460c16
Cr-Commit-Position: refs/heads/master@{#319115}

Powered by Google App Engine
This is Rietveld 408576698