Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10476)

Unified Diff: device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java

Issue 975963003: Address NewApi warning in device/battery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added assert Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/lint/suppressions.xml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java
diff --git a/device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java b/device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java
index b94c7f09f2e8ce59dfc3b55ca07e65c235f245bf..87fd280ed537350118460053fae285f66fa75cd1 100644
--- a/device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java
+++ b/device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java
@@ -4,6 +4,7 @@
package org.chromium.device.battery;
+import android.annotation.TargetApi;
import android.content.BroadcastReceiver;
import android.content.Context;
import android.content.Intent;
@@ -133,35 +134,44 @@ class BatteryStatusManager {
double chargingTimeSeconds = (charging && batteryFull) ? 0 : Double.POSITIVE_INFINITY;
double dischargingTimeSeconds = Double.POSITIVE_INFINITY;
- if (mLollipopBatteryManager != null) {
- // On Lollipop we can provide a better estimate for chargingTime and dischargingTime.
- double remainingCapacityRatio = mLollipopBatteryManager.getIntProperty(
- BatteryManager.BATTERY_PROPERTY_CAPACITY) / 100.0;
- double batteryCapacityMicroAh = mLollipopBatteryManager.getIntProperty(
- BatteryManager.BATTERY_PROPERTY_CHARGE_COUNTER);
- double averageCurrentMicroA = mLollipopBatteryManager.getIntProperty(
- BatteryManager.BATTERY_PROPERTY_CURRENT_AVERAGE);
-
- if (charging) {
- if (chargingTimeSeconds == Double.POSITIVE_INFINITY && averageCurrentMicroA > 0) {
- double chargeFromEmptyHours = batteryCapacityMicroAh / averageCurrentMicroA;
- chargingTimeSeconds =
- Math.ceil((1 - remainingCapacityRatio) * chargeFromEmptyHours * 3600.0);
- }
- } else {
- if (averageCurrentMicroA < 0) {
- double dischargeFromFullHours = batteryCapacityMicroAh / -averageCurrentMicroA;
- dischargingTimeSeconds =
- Math.floor(remainingCapacityRatio * dischargeFromFullHours * 3600.0);
- }
- }
- }
-
BatteryStatus batteryStatus = new BatteryStatus();
batteryStatus.charging = charging;
batteryStatus.chargingTime = chargingTimeSeconds;
batteryStatus.dischargingTime = dischargingTimeSeconds;
batteryStatus.level = level;
+
+ if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
+ updateBatteryStatusForLollipop(batteryStatus);
+ }
+
mCallback.onBatteryStatusChanged(batteryStatus);
}
+
+ @TargetApi(Build.VERSION_CODES.LOLLIPOP)
+ private void updateBatteryStatusForLollipop(BatteryStatus batteryStatus) {
+ assert mLollipopBatteryManager != null;
+
+ // On Lollipop we can provide a better estimate for chargingTime and dischargingTime.
+ double remainingCapacityRatio = mLollipopBatteryManager.getIntProperty(
+ BatteryManager.BATTERY_PROPERTY_CAPACITY) / 100.0;
+ double batteryCapacityMicroAh = mLollipopBatteryManager.getIntProperty(
+ BatteryManager.BATTERY_PROPERTY_CHARGE_COUNTER);
+ double averageCurrentMicroA = mLollipopBatteryManager.getIntProperty(
+ BatteryManager.BATTERY_PROPERTY_CURRENT_AVERAGE);
+
+ if (batteryStatus.charging) {
+ if (batteryStatus.chargingTime == Double.POSITIVE_INFINITY
+ && averageCurrentMicroA > 0) {
+ double chargeFromEmptyHours = batteryCapacityMicroAh / averageCurrentMicroA;
+ batteryStatus.chargingTime =
+ Math.ceil((1 - remainingCapacityRatio) * chargeFromEmptyHours * 3600.0);
+ }
+ } else {
+ if (averageCurrentMicroA < 0) {
+ double dischargeFromFullHours = batteryCapacityMicroAh / -averageCurrentMicroA;
+ batteryStatus.dischargingTime =
+ Math.floor(remainingCapacityRatio * dischargeFromFullHours * 3600.0);
+ }
+ }
+ }
}
« no previous file with comments | « build/android/lint/suppressions.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698