Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 975723002: Fix issues with Socket shutdown. (Closed)

Created:
5 years, 9 months ago by Bill Hesse
Modified:
5 years, 9 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix issues with Socket shutdown. BUG=dartbug.com/22637 BUG=dartbug.com/22636 Committed: https://code.google.com/p/dart/source/detail?r=44178

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix copyright date #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -2 lines) Patch
M runtime/bin/socket_patch.dart View 4 chunks +5 lines, -2 lines 0 comments Download
A tests/standalone/io/issue_22637_test.dart View 1 1 chunk +68 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (1 generated)
Bill Hesse
TBR=sgjesse@google.com https://codereview.chromium.org/975723002/diff/1/tests/standalone/io/issue_22637_test.dart File tests/standalone/io/issue_22637_test.dart (right): https://codereview.chromium.org/975723002/diff/1/tests/standalone/io/issue_22637_test.dart#newcode1 tests/standalone/io/issue_22637_test.dart:1: // Copyright (c) 2013, the Dart project authors. ...
5 years, 9 months ago (2015-03-03 16:17:45 UTC) #2
Bill Hesse
Committed patchset #2 (id:20001) manually as 44178 (presubmit successful).
5 years, 9 months ago (2015-03-03 16:19:30 UTC) #3
Søren Gjesse
5 years, 9 months ago (2015-03-04 09:22:00 UTC) #4
Message was sent while issue was closed. 
A few comments even though this was reverted.

https://codereview.chromium.org/975723002/diff/20001/tests/standalone/io/issu...
File tests/standalone/io/issue_22637_test.dart (right):

https://codereview.chromium.org/975723002/diff/20001/tests/standalone/io/issu...
tests/standalone/io/issue_22637_test.dart:7: // that remains in the connection.
Shouldn't we also have a tests that checks that only one READ_CLOSED event is
generated? You have some code which could generate several READ_CLOSED events
without this change.

https://codereview.chromium.org/975723002/diff/20001/tests/standalone/io/issu...
tests/standalone/io/issue_22637_test.dart:59: server = await
RawServerSocket.bind("localhost", 1968);
Please don't use fixed port numbers in tests.

Powered by Google App Engine
This is Rietveld 408576698