Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 975693002: Revert of Implement subclassing Arrays. (Closed)

Created:
5 years, 9 months ago by mvstanton
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Implement subclassing Arrays. (patchset #6 id:90001 of https://codereview.chromium.org/975463002/) Reason for revert: ARM build failure... Original issue's description: > Implement subclassing Arrays. > > R=mvstanton@chromium.org,arv@chromium.org,rossberg@chromium.org > BUG=v8:3930 > LOG=Y > > Committed: https://crrev.com/6898da1a28d64d1fb2962804ba566f6d618ffc70 > Cr-Commit-Position: refs/heads/master@{#26960} TBR=arv@chromium.org,rossberg@chromium.org,dslomov@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3930 Committed: https://crrev.com/01e2ba6e19a27ba43788693cebf368190d8337f9 Cr-Commit-Position: refs/heads/master@{#26961}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -308 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +1 line, -19 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 2 chunks +4 lines, -19 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +5 lines, -23 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +4 lines, -23 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 2 chunks +3 lines, -22 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-array.cc View 4 chunks +2 lines, -28 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +1 line, -23 lines 0 comments Download
D test/mjsunit/harmony/classes-subclass-arrays.js View 1 chunk +0 lines, -150 lines 0 comments Download
A test/mjsunit/harmony/regress/regress-3930.js View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mvstanton
Created Revert of Implement subclassing Arrays.
5 years, 9 months ago (2015-03-03 14:55:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/975693002/1
5 years, 9 months ago (2015-03-03 14:55:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 14:56:07 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 14:56:19 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01e2ba6e19a27ba43788693cebf368190d8337f9
Cr-Commit-Position: refs/heads/master@{#26961}

Powered by Google App Engine
This is Rietveld 408576698