Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 975663002: Remove the distinction between informational and warning infobar (Closed)

Created:
5 years, 9 months ago by sdefresne
Modified:
5 years, 9 months ago
Reviewers:
droger
CC:
chromium-reviews, bdibello
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the distinction between informational and warning infobar The need to make the distinction between the two types of infobars has disappeared with the new design of the infobars. BUG=None Committed: https://crrev.com/7764ad3d29cf888a78f0d4d513d0c4f76650d335 Cr-Commit-Position: refs/heads/master@{#318896}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -27 lines) Patch
M ios/chrome/browser/infobars/confirm_infobar_controller.mm View 1 chunk +1 line, -3 lines 0 comments Download
M ios/chrome/browser/translate/after_translate_infobar_controller.mm View 1 chunk +1 line, -5 lines 0 comments Download
M ios/chrome/browser/translate/before_translate_infobar_controller.mm View 1 chunk +1 line, -5 lines 0 comments Download
M ios/chrome/browser/translate/never_translate_infobar_controller.mm View 1 chunk +1 line, -5 lines 0 comments Download
M ios/chrome/browser/translate/translate_message_infobar_controller.mm View 1 chunk +1 line, -5 lines 0 comments Download
M ios/public/provider/chrome/browser/ui/infobar_view_protocol.h View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sdefresne
PTAL
5 years, 9 months ago (2015-03-03 10:33:40 UTC) #2
droger
lgtm
5 years, 9 months ago (2015-03-03 17:03:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/975663002/1
5 years, 9 months ago (2015-03-03 17:03:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 17:07:42 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 17:08:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7764ad3d29cf888a78f0d4d513d0c4f76650d335
Cr-Commit-Position: refs/heads/master@{#318896}

Powered by Google App Engine
This is Rietveld 408576698