ios/chrome/browser/translate/before_translate_infobar_controller.mm - Issue 975663002: Remove the distinction between informational and warning infobar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/translate/before_translate_infobar_controller.mm

Issue 975663002: Remove the distinction between informational and warning infobar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/translate/after_translate_infobar_controller.mm ('k') | ios/chrome/browser/translate/never_translate_infobar_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/translate/before_translate_infobar_controller.mm

diff --git a/ios/chrome/browser/translate/before_translate_infobar_controller.mm b/ios/chrome/browser/translate/before_translate_infobar_controller.mm

index 8b98d4b830151e9e8c429752dffed19b19528cf5..72aed8c124e3acc418a846985c77fdc3e9ff2e59 100644

--- a/ios/chrome/browser/translate/before_translate_infobar_controller.mm

+++ b/ios/chrome/browser/translate/before_translate_infobar_controller.mm

@@ -127,14 +127,10 @@ NSTimeInterval kPickerAnimationDurationInSeconds = 0.2;

- (void)layoutForDelegate:(infobars::InfoBarDelegate*)delegate

frame:(CGRect)frame {

_translateInfoBarDelegate = delegate->AsTranslateInfoBarDelegate();

- infobars::InfoBarDelegate* infoBarDelegate =

- static_cast<infobars::InfoBarDelegate*>(_translateInfoBarDelegate);

DCHECK(!infoBarView_);

infoBarView_.reset([ios::GetChromeBrowserProvider()->CreateInfoBarView()

initWithFrame:frame

- delegate:delegate_

- isWarning:infoBarDelegate->GetInfoBarType() ==

- infobars::InfoBarDelegate::WARNING_TYPE]);

+ delegate:delegate_]);

// Icon

gfx::Image icon = _translateInfoBarDelegate->GetIcon();

if (!icon.IsEmpty())