Encrypt certificate logger requests for extended reporting

chrome/browser/net/chrome_fraudulent_certificate_reporter.h

Index: chrome/browser/net/chrome_fraudulent_certificate_reporter.h
diff --git a/chrome/browser/net/chrome_fraudulent_certificate_reporter.h b/chrome/browser/net/chrome_fraudulent_certificate_reporter.h
index 987a485bceb5e4704e5c00bfb76adb84a77f0cd2..9985d9436f7e4552b04a6dec85f29b81c2e62367 100644
--- a/chrome/browser/net/chrome_fraudulent_certificate_reporter.h
+++ b/chrome/browser/net/chrome_fraudulent_certificate_reporter.h
@@ -17,6 +17,8 @@ class URLRequestContext;
 
 namespace chrome_browser_net {
 
+class EncryptedCertLoggerRequest;
+
 class ChromeFraudulentCertificateReporter
     : public net::FraudulentCertificateReporter,
       public net::URLRequest::Delegate {
@@ -56,6 +58,15 @@ class ChromeFraudulentCertificateReporter
   DISALLOW_COPY_AND_ASSIGN(ChromeFraudulentCertificateReporter);
 };
 
+void CalculateSymmetricKeys(const uint8* client_private_key,

[agl, 2015/03/05 19:22:26]

this can be written:
  const uint8 client_private_key[32]

Which is the same thing, but documents the expected length in the header if you
like. (Same for several cases below.)

+                            const uint8* server_public_key,
+                            std::string& aes_key,

[agl, 2015/03/05 19:22:25]

These are outputs? If so, it should be a std::string*.

+                            std::string& hmac_key);
+bool EncryptSerializedReport(const uint8* server_public_key,
+                             uint32 server_public_key_version,
+                             const std::string& report,
+                             EncryptedCertLoggerRequest& encrypted_report);

[agl, 2015/03/05 19:22:25]

If encrypted_report is an output, it should be a pointer.

+
 }  // namespace chrome_browser_net
 
 #endif  // CHROME_BROWSER_NET_CHROME_FRAUDULENT_CERTIFICATE_REPORTER_H_