Encrypt certificate logger requests for extended reporting

chrome/browser/net/chrome_fraudulent_certificate_reporter.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NET_CHROME_FRAUDULENT_CERTIFICATE_REPORTER_H_
 #define CHROME_BROWSER_NET_CHROME_FRAUDULENT_CERTIFICATE_REPORTER_H_
 
 #include <set>
 #include <string>
 
 #include "net/url_request/fraudulent_certificate_reporter.h"
 #include "net/url_request/url_request.h"
 
 namespace net {
 class URLRequestContext;
 }
 
 namespace chrome_browser_net {
 
+class EncryptedCertLoggerRequest;
+
 class ChromeFraudulentCertificateReporter
     : public net::FraudulentCertificateReporter,
       public net::URLRequest::Delegate {
  public:
   explicit ChromeFraudulentCertificateReporter(
       net::URLRequestContext* request_context);
 
   ~ChromeFraudulentCertificateReporter() override;
 
   // Allows users of this class to override this and set their own URLRequest
@@ skipping 19 matching lines @@
  private:
   // Performs post-report cleanup.
   void RequestComplete(net::URLRequest* request);
 
   // Owns the contained requests.
   std::set<net::URLRequest*> inflight_requests_;
 
   DISALLOW_COPY_AND_ASSIGN(ChromeFraudulentCertificateReporter);
 };
 
+void CalculateSymmetricKeys(const uint8* client_private_key,

[agl, 2015/03/05 19:22:26]

this can be written:
  const uint8 client_private_key[32]

Which is the same thing, but documents the expected length in the header if you
like. (Same for several cases below.)

+                            const uint8* server_public_key,
+                            std::string& aes_key,

[agl, 2015/03/05 19:22:25]

These are outputs? If so, it should be a std::string*.

+                            std::string& hmac_key);
+bool EncryptSerializedReport(const uint8* server_public_key,
+                             uint32 server_public_key_version,
+                             const std::string& report,
+                             EncryptedCertLoggerRequest& encrypted_report);

[agl, 2015/03/05 19:22:25]

If encrypted_report is an output, it should be a pointer.

+
 }  // namespace chrome_browser_net
 
 #endif  // CHROME_BROWSER_NET_CHROME_FRAUDULENT_CERTIFICATE_REPORTER_H_