Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 975613002: QUIC - minor cleanup of the following field trials and used defaults for (Closed)

Created:
5 years, 9 months ago by ramant (doing other things)
Modified:
5 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - minor cleanup of the following field trials and used defaults for them. "enable_truncated_connection_ids": "true", "load_server_info_time_to_srtt": "0.25" Deleted "load_server_info_timeout" field trial, because "load_server_info_time_to_srtt" field trial accomplishes the same in a better manner. R=rch@chromium.org Committed: https://crrev.com/ca75eb1bbd333f49980b85a4a261999661db348f Cr-Commit-Position: refs/heads/master@{#318957}

Patch Set 1 #

Total comments: 4

Patch Set 2 : set default value for srtt_multiplier in net #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -163 lines) Patch
M chrome/browser/io_thread.h View 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/io_thread.cc View 1 5 chunks +0 lines, -36 lines 0 comments Download
M chrome/browser/io_thread_unittest.cc View 3 chunks +1 line, -21 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/http/http_network_session.cc View 1 2 chunks +1 line, -5 lines 0 comments Download
M net/quic/quic_stream_factory.h View 2 chunks +0 lines, -10 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 4 chunks +9 lines, -16 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 4 chunks +0 lines, -61 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
ramant (doing other things)
Hi Ryan, Changed the code to use defaults as we had talked offline. PTAL. thanks.
5 years, 9 months ago (2015-03-03 02:25:32 UTC) #2
Ryan Hamilton
One minor suggestion https://codereview.chromium.org/975613002/diff/1/chrome/browser/io_thread.cc File chrome/browser/io_thread.cc (right): https://codereview.chromium.org/975613002/diff/1/chrome/browser/io_thread.cc#newcode1345 chrome/browser/io_thread.cc:1345: return 0.25f; I think that the ...
5 years, 9 months ago (2015-03-03 05:11:13 UTC) #3
ramant (doing other things)
https://codereview.chromium.org/975613002/diff/1/chrome/browser/io_thread.cc File chrome/browser/io_thread.cc (right): https://codereview.chromium.org/975613002/diff/1/chrome/browser/io_thread.cc#newcode1345 chrome/browser/io_thread.cc:1345: return 0.25f; On 2015/03/03 05:11:13, Ryan Hamilton wrote: > ...
5 years, 9 months ago (2015-03-03 17:15:11 UTC) #4
Ryan Hamilton
lgtm
5 years, 9 months ago (2015-03-03 21:56:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/975613002/20001
5 years, 9 months ago (2015-03-03 22:01:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-03 23:09:59 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 23:11:11 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ca75eb1bbd333f49980b85a4a261999661db348f
Cr-Commit-Position: refs/heads/master@{#318957}

Powered by Google App Engine
This is Rietveld 408576698