Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Side by Side Diff: chrome/browser/io_thread_unittest.cc

Issue 975613002: QUIC - minor cleanup of the following field trials and used defaults for (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: set default value for srtt_multiplier in net Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | net/http/http_network_session.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/metrics/field_trial.h" 6 #include "base/metrics/field_trial.h"
7 #include "chrome/browser/io_thread.h" 7 #include "chrome/browser/io_thread.h"
8 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_param s.h" 8 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_param s.h"
9 #include "net/http/http_network_session.h" 9 #include "net/http/http_network_session.h"
10 #include "net/http/http_server_properties_impl.h" 10 #include "net/http/http_server_properties_impl.h"
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 InitializeNetworkSessionParams(&params); 128 InitializeNetworkSessionParams(&params);
129 EXPECT_TRUE(params.enable_quic); 129 EXPECT_TRUE(params.enable_quic);
130 EXPECT_TRUE(params.enable_quic_for_proxies); 130 EXPECT_TRUE(params.enable_quic_for_proxies);
131 EXPECT_EQ(1350u, params.quic_max_packet_length); 131 EXPECT_EQ(1350u, params.quic_max_packet_length);
132 EXPECT_EQ(1.0, params.alternate_protocol_probability_threshold); 132 EXPECT_EQ(1.0, params.alternate_protocol_probability_threshold);
133 EXPECT_EQ(default_params.quic_supported_versions, 133 EXPECT_EQ(default_params.quic_supported_versions,
134 params.quic_supported_versions); 134 params.quic_supported_versions);
135 EXPECT_EQ(net::QuicTagVector(), params.quic_connection_options); 135 EXPECT_EQ(net::QuicTagVector(), params.quic_connection_options);
136 EXPECT_FALSE(params.quic_always_require_handshake_confirmation); 136 EXPECT_FALSE(params.quic_always_require_handshake_confirmation);
137 EXPECT_FALSE(params.quic_disable_connection_pooling); 137 EXPECT_FALSE(params.quic_disable_connection_pooling);
138 EXPECT_EQ(0, params.quic_load_server_info_timeout_ms); 138 EXPECT_EQ(0.25f, params.quic_load_server_info_timeout_srtt_multiplier);
139 EXPECT_EQ(0.0f, params.quic_load_server_info_timeout_srtt_multiplier);
140 EXPECT_FALSE(params.quic_enable_truncated_connection_ids);
141 EXPECT_FALSE(params.quic_enable_connection_racing); 139 EXPECT_FALSE(params.quic_enable_connection_racing);
142 EXPECT_FALSE(params.quic_enable_non_blocking_io); 140 EXPECT_FALSE(params.quic_enable_non_blocking_io);
143 EXPECT_FALSE(params.quic_disable_disk_cache); 141 EXPECT_FALSE(params.quic_disable_disk_cache);
144 EXPECT_FALSE(IOThread::ShouldEnableQuicForDataReductionProxy()); 142 EXPECT_FALSE(IOThread::ShouldEnableQuicForDataReductionProxy());
145 } 143 }
146 144
147 TEST_F(IOThreadTest, EnableQuicFromQuicProxyFieldTrialGroup) { 145 TEST_F(IOThreadTest, EnableQuicFromQuicProxyFieldTrialGroup) {
148 base::FieldTrialList field_trial_list(new BadEntropyProvider()); 146 base::FieldTrialList field_trial_list(new BadEntropyProvider());
149 base::FieldTrialList::CreateFieldTrial( 147 base::FieldTrialList::CreateFieldTrial(
150 data_reduction_proxy::DataReductionProxyParams::GetQuicFieldTrialName(), 148 data_reduction_proxy::DataReductionProxyParams::GetQuicFieldTrialName(),
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
287 TEST_F(IOThreadTest, 285 TEST_F(IOThreadTest,
288 QuicDisableConnectionPoolingFromFieldTrialParams) { 286 QuicDisableConnectionPoolingFromFieldTrialParams) {
289 field_trial_group_ = "Enabled"; 287 field_trial_group_ = "Enabled";
290 field_trial_params_["disable_connection_pooling"] = "true"; 288 field_trial_params_["disable_connection_pooling"] = "true";
291 ConfigureQuicGlobals(); 289 ConfigureQuicGlobals();
292 net::HttpNetworkSession::Params params; 290 net::HttpNetworkSession::Params params;
293 InitializeNetworkSessionParams(&params); 291 InitializeNetworkSessionParams(&params);
294 EXPECT_TRUE(params.quic_disable_connection_pooling); 292 EXPECT_TRUE(params.quic_disable_connection_pooling);
295 } 293 }
296 294
297 TEST_F(IOThreadTest, QuicLoadServerInfoTimeoutFromFieldTrialParams) {
298 field_trial_group_ = "Enabled";
299 field_trial_params_["load_server_info_timeout"] = "50";
300 ConfigureQuicGlobals();
301 net::HttpNetworkSession::Params params;
302 InitializeNetworkSessionParams(&params);
303 EXPECT_EQ(50, params.quic_load_server_info_timeout_ms);
304 }
305
306 TEST_F(IOThreadTest, QuicLoadServerInfoTimeToSmoothedRttFromFieldTrialParams) { 295 TEST_F(IOThreadTest, QuicLoadServerInfoTimeToSmoothedRttFromFieldTrialParams) {
307 field_trial_group_ = "Enabled"; 296 field_trial_group_ = "Enabled";
308 field_trial_params_["load_server_info_time_to_srtt"] = "0.5"; 297 field_trial_params_["load_server_info_time_to_srtt"] = "0.5";
309 ConfigureQuicGlobals(); 298 ConfigureQuicGlobals();
310 net::HttpNetworkSession::Params params; 299 net::HttpNetworkSession::Params params;
311 InitializeNetworkSessionParams(&params); 300 InitializeNetworkSessionParams(&params);
312 EXPECT_EQ(0.5f, params.quic_load_server_info_timeout_srtt_multiplier); 301 EXPECT_EQ(0.5f, params.quic_load_server_info_timeout_srtt_multiplier);
313 } 302 }
314 303
315 TEST_F(IOThreadTest, QuicEnableTruncatedConnectionIds) {
316 field_trial_group_ = "Enabled";
317 field_trial_params_["enable_truncated_connection_ids"] = "true";
318 ConfigureQuicGlobals();
319 net::HttpNetworkSession::Params params;
320 InitializeNetworkSessionParams(&params);
321 EXPECT_TRUE(params.quic_enable_truncated_connection_ids);
322 }
323
324 TEST_F(IOThreadTest, QuicEnableConnectionRacing) { 304 TEST_F(IOThreadTest, QuicEnableConnectionRacing) {
325 field_trial_group_ = "Enabled"; 305 field_trial_group_ = "Enabled";
326 field_trial_params_["enable_connection_racing"] = "true"; 306 field_trial_params_["enable_connection_racing"] = "true";
327 ConfigureQuicGlobals(); 307 ConfigureQuicGlobals();
328 net::HttpNetworkSession::Params params; 308 net::HttpNetworkSession::Params params;
329 InitializeNetworkSessionParams(&params); 309 InitializeNetworkSessionParams(&params);
330 EXPECT_TRUE(params.quic_enable_connection_racing); 310 EXPECT_TRUE(params.quic_enable_connection_racing);
331 } 311 }
332 312
333 TEST_F(IOThreadTest, QuicEnableNonBlockingIO) { 313 TEST_F(IOThreadTest, QuicEnableNonBlockingIO) {
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
383 field_trial_group_ = "Enabled"; 363 field_trial_group_ = "Enabled";
384 field_trial_params_["alternate_protocol_probability_threshold"] = ".5"; 364 field_trial_params_["alternate_protocol_probability_threshold"] = ".5";
385 365
386 ConfigureQuicGlobals(); 366 ConfigureQuicGlobals();
387 net::HttpNetworkSession::Params params; 367 net::HttpNetworkSession::Params params;
388 InitializeNetworkSessionParams(&params); 368 InitializeNetworkSessionParams(&params);
389 EXPECT_EQ(.5, params.alternate_protocol_probability_threshold); 369 EXPECT_EQ(.5, params.alternate_protocol_probability_threshold);
390 } 370 }
391 371
392 } // namespace test 372 } // namespace test
OLDNEW
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | net/http/http_network_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698