Implement subclassing Arrays.

Implement subclassing Arrays.

R=mvstanton@chromium.org,arv@chromium.org,rossberg@chromium.org
BUG=v8:3930
LOG=Y

Committed: https://crrev.com/6898da1a28d64d1fb2962804ba566f6d618ffc70
Cr-Commit-Position: refs/heads/master@{#26960}

Committed: https://crrev.com/8d29cc11a56e77297792fe100986a80b65de0051
Cr-Commit-Position: refs/heads/master@{#26963}

Committed: https://crrev.com/0705045b50a29cf1273e9e6b86fe6a627d8dcb43
Cr-Commit-Position: refs/heads/master@{#26966}

Committed: https://crrev.com/1604bd46bf7fe0a8f7cd7780174030e26b93ab37
Cr-Commit-Position: refs/heads/master@{#26972}

[Dmitry Lomov (no reviews), 2015-03-02 15:40:42]

dslomov@chromium.org changed required reviewers:
+ arv@chromium.org, mvstanton@chromium.org

[Dmitry Lomov (no reviews), 2015-03-02 15:43:41]

PTAL before platform ports

[mvstanton, 2015-03-02 16:46:19]

Just one nit, looks pretty good. Also, just a reminder per our discussion on the
MORE_THAN_ONE case where we weren't sure if eax was initialized with the correct
number of arguments.

https://codereview.chromium.org/975463002/diff/20001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):

https://codereview.chromium.org/975463002/diff/20001/src/ia32/code-stubs-ia32...
src/ia32/code-stubs-ia32.cc:4679: __ add(eax, Immediate(2));
A comment about the add would be good, or maybe an overview comment indicating
that you are cleverly altering the arguments length.

[Dmitry Lomov (no reviews), 2015-03-02 17:22:30]

All ports done, please take a look.

[arv (Not doing code reviews), 2015-03-03 09:01:16]

The code looks good but I still want a test that asserts that the instance is an
exotic array object. I would like at least Array.isArray and a case using concat
(maybe even JSON.stringify)

[Dmitry Lomov (no reviews), 2015-03-03 10:17:20]

Tests added, PTAL

[arv (Not doing code reviews), 2015-03-03 13:11:41]

LGTM

https://codereview.chromium.org/975463002/diff/70001/test/mjsunit/harmony/cla...
File test/mjsunit/harmony/classes-subclass-arrays.js (right):

https://codereview.chromium.org/975463002/diff/70001/test/mjsunit/harmony/cla...
test/mjsunit/harmony/classes-subclass-arrays.js:20: assertEquals('xyz', s1[0]);
Inconsistent use of assertSame and assertEquals?

[mvstanton, 2015-03-03 13:13:55]

lgtm

[Dmitry Lomov (no reviews), 2015-03-03 13:17:39]

The CQ bit was checked by dslomov@chromium.org

[Dmitry Lomov (no reviews), 2015-03-03 13:17:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org, arv@chromium.org
Link to the patchset: https://codereview.chromium.org/975463002/#ps90001 (title:
"CR feedback + rebase")

[commit-bot: I haz the power, 2015-03-03 13:18:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/975463002/90001

[commit-bot: I haz the power, 2015-03-03 13:40:37]

Committed patchset #6 (id:90001)

[commit-bot: I haz the power, 2015-03-03 13:40:46]

Patchset 6 (id:??) landed as
https://crrev.com/6898da1a28d64d1fb2962804ba566f6d618ffc70
Cr-Commit-Position: refs/heads/master@{#26960}

[mvstanton, 2015-03-03 14:55:01]

A revert of this CL (patchset #6 id:90001) has been created in
https://codereview.chromium.org/975693002/ by mvstanton@chromium.org.

The reason for reverting is: ARM build failure....

[Dmitry Lomov (no reviews), 2015-03-03 15:16:01]

mvstanton@ PTAL at compilation fix in patch set 7

[mvstanton, 2015-03-03 15:23:21]

lgtm

[Dmitry Lomov (no reviews), 2015-03-03 15:23:39]

The CQ bit was checked by dslomov@chromium.org

[Dmitry Lomov (no reviews), 2015-03-03 15:23:39]

The patchset sent to the CQ was uploaded after l-g-t-m from arv@chromium.org
Link to the patchset: https://codereview.chromium.org/975463002/#ps110001
(title: "arm compilation fix")

[commit-bot: I haz the power, 2015-03-03 15:24:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/975463002/110001

[commit-bot: I haz the power, 2015-03-03 16:10:32]

Committed patchset #7 (id:110001)

[commit-bot: I haz the power, 2015-03-03 16:10:49]

Patchset 7 (id:??) landed as
https://crrev.com/8d29cc11a56e77297792fe100986a80b65de0051
Cr-Commit-Position: refs/heads/master@{#26963}

[Dmitry Lomov (no reviews), 2015-03-03 16:40:11]

A revert of this CL (patchset #7 id:110001) has been created in
https://codereview.chromium.org/974963002/ by dslomov@chromium.org.

The reason for reverting is: Arm buildre complains again (why v8_linux_arm_dbg
does not complain?).

[Dmitry Lomov (no reviews), 2015-03-03 16:50:21]

mvstanton@, PTAL at patch set 8. Argh.

[mvstanton, 2015-03-03 16:51:42]

lgtm

[Dmitry Lomov (no reviews), 2015-03-03 16:51:59]

The CQ bit was checked by dslomov@chromium.org

[Dmitry Lomov (no reviews), 2015-03-03 16:52:00]

The patchset sent to the CQ was uploaded after l-g-t-m from arv@chromium.org
Link to the patchset: https://codereview.chromium.org/975463002/#ps130001
(title: "Another attempt at fix for arm :(")

[commit-bot: I haz the power, 2015-03-03 16:52:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/975463002/130001

[commit-bot: I haz the power, 2015-03-03 17:14:13]

Committed patchset #8 (id:130001)

[commit-bot: I haz the power, 2015-03-03 17:14:25]

Patchset 8 (id:??) landed as
https://crrev.com/0705045b50a29cf1273e9e6b86fe6a627d8dcb43
Cr-Commit-Position: refs/heads/master@{#26966}

[Dmitry Lomov (no reviews), 2015-03-03 17:47:22]

A revert of this CL (patchset #8 id:130001) has been created in
https://codereview.chromium.org/976693002/ by dslomov@chromium.org.

The reason for reverting is: Arm compilation again.

Aaaarrrrrghhhhhh!!!.

[Dmitry Lomov (no reviews), 2015-03-03 18:12:09]

arv@ could you take a look at this another attempt at fixing arm?
I have validated locally that it builds with a cross-compiler.

[arv (Not doing code reviews), 2015-03-03 18:15:21]

LGTM

https://codereview.chromium.org/975463002/diff/150001/src/runtime/runtime-arr...
File src/runtime/runtime-array.cc (right):

https://codereview.chromium.org/975463002/diff/150001/src/runtime/runtime-arr...
src/runtime/runtime-array.cc:1167: CHECK(args_length >= 2);
Does this need to be a CHECK and not a DCHECK?

[Dmitry Lomov (no reviews), 2015-03-03 18:18:08]

https://codereview.chromium.org/975463002/diff/150001/src/runtime/runtime-arr...
File src/runtime/runtime-array.cc (right):

https://codereview.chromium.org/975463002/diff/150001/src/runtime/runtime-arr...
src/runtime/runtime-array.cc:1167: CHECK(args_length >= 2);
On 2015/03/03 18:15:20, arv wrote:
> Does this need to be a CHECK and not a DCHECK?

CHECK is safer (and does not cost us much)

[Dmitry Lomov (no reviews), 2015-03-03 18:18:15]

The CQ bit was checked by dslomov@chromium.org

[Dmitry Lomov (no reviews), 2015-03-03 18:18:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org
Link to the patchset: https://codereview.chromium.org/975463002/#ps150001
(title: "Fix arm again")

[commit-bot: I haz the power, 2015-03-03 18:19:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/975463002/150001

[commit-bot: I haz the power, 2015-03-03 18:45:07]

Committed patchset #9 (id:150001)

[commit-bot: I haz the power, 2015-03-03 18:45:14]

Patchset 9 (id:??) landed as
https://crrev.com/1604bd46bf7fe0a8f7cd7780174030e26b93ab37
Cr-Commit-Position: refs/heads/master@{#26972}