Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 975443004: Adds the ability for 'copies' in Xcode project files to specify the 'Code Sign on Copy' option. (Closed)

Created:
5 years, 9 months ago by bradn
Modified:
5 years, 9 months ago
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Adds the ability for 'copies' in Xcode project files to specify the 'Code Sign on Copy' option. Relanding change landed in svn: https://codereview.chromium.org/956203005/ Original author: mattryavec@google.com BUG=None R=mark@chromium.org, thakis@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/a5bd08f286297d3dac5ff4fd27a97e7961412513

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M pylib/gyp/generator/xcode.py View 2 chunks +4 lines, -1 line 0 comments Download
M test/mac/framework/framework.gyp View 1 chunk +23 lines, -0 lines 0 comments Download
M test/mac/gyptest-copies.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bradn
5 years, 9 months ago (2015-03-02 18:11:44 UTC) #2
Mark Mentovai
Can you copy the issue description as it landed in svn, with the attribution to ...
5 years, 9 months ago (2015-03-02 18:13:37 UTC) #3
bradn
This was the commit message from that commit. I've added a link to the old ...
5 years, 9 months ago (2015-03-02 18:22:29 UTC) #5
Mark Mentovai
LGTM
5 years, 9 months ago (2015-03-02 18:46:27 UTC) #6
bradn
5 years, 9 months ago (2015-03-02 18:55:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a5bd08f286297d3dac5ff4fd27a97e7961412513.

Powered by Google App Engine
This is Rietveld 408576698