Adds the ability for 'copies' in Xcode project files to specify the 'Code Sign on Copy' option.

Adds the ability for 'copies' in Xcode project files to specify the 'Code Sign on Copy' option.

BUG=

[mattryavec, 2015-02-26 17:07:32]

mattryavec@google.com changed reviewers:
+ thakis@chromium.org

[Nico, 2015-02-26 19:05:44]

thakis@chromium.org changed reviewers:
+ mark@chromium.org

[Nico, 2015-02-26 19:05:44]

This looks fine to me (thanks for adding a test!), but Mark should probably
bless changes to the xcode generator.

https://codereview.chromium.org/956203005/diff/1/test/mac/framework/framework...
File test/mac/framework/framework.gyp (right):

https://codereview.chromium.org/956203005/diff/1/test/mac/framework/framework...
test/mac/framework/framework.gyp:86: 'action_name': 'aektschn',
:-)

[Nico, 2015-02-26 19:06:34]

https://codereview.chromium.org/956203005/diff/1/test/mac/framework/framework...
File test/mac/framework/framework.gyp (right):

https://codereview.chromium.org/956203005/diff/1/test/mac/framework/framework...
test/mac/framework/framework.gyp:81: 'code_sign': 1,
maybe this should be xcode_code_sign or something that makes clear that this is
mac/ios-specific. (Mark should probably decree what to call this.)

[Mark Mentovai, 2015-02-26 21:35:13]

https://codereview.chromium.org/956203005/diff/1/pylib/gyp/generator/xcode.py
File pylib/gyp/generator/xcode.py (right):

https://codereview.chromium.org/956203005/diff/1/pylib/gyp/generator/xcode.py...
pylib/gyp/generator/xcode.py:1133: code_sign = int(copy_group.get('code_sign',
0))
I agree, please change this to xcode_code_sign and then this LGTM.

[mattryavec, 2015-02-26 21:50:32]

On 2015/02/26 21:35:13, Mark Mentovai wrote:
> https://codereview.chromium.org/956203005/diff/1/pylib/gyp/generator/xcode.py
> File pylib/gyp/generator/xcode.py (right):
> 
>
https://codereview.chromium.org/956203005/diff/1/pylib/gyp/generator/xcode.py...
> pylib/gyp/generator/xcode.py:1133: code_sign = int(copy_group.get('code_sign',
> 0))
> I agree, please change this to xcode_code_sign and then this LGTM.

Done!

[mattryavec, 2015-02-26 21:52:16]

https://codereview.chromium.org/956203005/diff/1/test/mac/framework/framework...
File test/mac/framework/framework.gyp (right):

https://codereview.chromium.org/956203005/diff/1/test/mac/framework/framework...
test/mac/framework/framework.gyp:81: 'code_sign': 1,
On 2015/02/26 19:06:34, Nico wrote:
> maybe this should be xcode_code_sign or something that makes clear that this
is
> mac/ios-specific. (Mark should probably decree what to call this.)

Done.

https://codereview.chromium.org/956203005/diff/1/test/mac/framework/framework...
test/mac/framework/framework.gyp:86: 'action_name': 'aektschn',
On 2015/02/26 19:05:44, Nico wrote:
> :-)

Totally :)

[mattryavec, 2015-02-26 21:54:58]

The CQ bit was checked by mattryavec@google.com

[mattryavec, 2015-02-26 21:54:58]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org
Link to the patchset: https://codereview.chromium.org/956203005/#ps20001 (title:
" ")

[commit-bot: I haz the power, 2015-02-26 21:58:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-26 21:58:49]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[mattryavec, 2015-02-26 21:59:32]

The CQ bit was checked by mattryavec@google.com

[commit-bot: I haz the power, 2015-02-26 22:03:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-26 22:03:52]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[mattryavec, 2015-02-26 22:07:14]

On 2015/02/26 22:03:52, I haz the power (commit-bot) wrote:
> Commit queue rejected this change because it did not recognize the base URL.
> Please commit your change manually.

Mark, Nico, what's up here? Does one of you need to manually commit this?

[Mark Mentovai, 2015-02-26 23:28:22]

Committed r2036