Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 975393002: Recognize GC_PLUGIN_IGNORE() on 'operator new' declarations. (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Recognize GC_PLUGIN_IGNORE() on 'operator new' declarations. For the select few times an overriding "operator new" is needed for a GC class, provide the GC_PLUGIN_IGNORE() escape hatch for these. The responsibility that the "new"'s allocation will be on the Oilpan heap, rests with the implementor of the class. R=haraken BUG=443854 Committed: https://crrev.com/3077ee89020f929c9c9a4eda8154a028523e6274 Cr-Commit-Position: refs/heads/master@{#319141}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
Please take a look. This is also needed for crbug.com/456823
5 years, 9 months ago (2015-03-04 14:31:53 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-04 14:46:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/975393002/1
5 years, 9 months ago (2015-03-04 22:01:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 22:26:24 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 22:27:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3077ee89020f929c9c9a4eda8154a028523e6274
Cr-Commit-Position: refs/heads/master@{#319141}

Powered by Google App Engine
This is Rietveld 408576698