tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp - Issue 975393002: Recognize GC_PLUGIN_IGNORE() on 'operator new' declarations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp

Issue 975393002: Recognize GC_PLUGIN_IGNORE() on 'operator new' declarations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp

diff --git a/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp b/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp

index dc36bef4145e325e87d5553d339eaeb673e33cc2..25c6a68fc5b39f3a85e134199d53bcb7bf369420 100644

--- a/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp

+++ b/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp

@@ -1125,7 +1125,8 @@ class BlinkGCPluginConsumer : public ASTConsumer {

CheckLeftMostDerived(info);

CheckDispatch(info);

if (CXXMethodDecl* newop = info->DeclaresNewOperator())

- ReportClassOverridesNew(info, newop);

+ if (!Config::IsIgnoreAnnotated(newop))

+ ReportClassOverridesNew(info, newop);

if (info->IsGCMixinInstance()) {

// Require that declared GCMixin implementations

// also provide a trace() override.

« no previous file with comments | « no previous file | no next file » | no next file with comments »