Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10334)

Unified Diff: android_webview/lib/main/webview_entry_point.cc

Issue 975253002: refactoring Android Webview JNI_OnLoad interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove at exit manager change Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/lib/main/webview_jni_onload.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/lib/main/webview_entry_point.cc
diff --git a/android_webview/lib/main/webview_entry_point.cc b/android_webview/lib/main/webview_entry_point.cc
index 1dff517d37d2443681cb1e07c4e9162068875c35..12d0fa99df1ae2b1a2cf53bdf482d7881bda5532 100644
--- a/android_webview/lib/main/webview_entry_point.cc
+++ b/android_webview/lib/main/webview_entry_point.cc
@@ -4,22 +4,23 @@
#include "android_webview/lib/main/webview_jni_onload.h"
#include "base/android/jni_android.h"
-#include "base/bind.h"
-#include "content/public/app/content_jni_onload.h"
// This is called by the VM when the shared library is first loaded.
// Most of the initialization is done in LibraryLoadedOnMainThread(), not here.
JNI_EXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) {
- // WebView uses native JNI exports; disable manual JNI registration to
- // improve startup peformance.
+ // WebView uses native JNI exports; disable manual JNI registration because
+ // we don't have a good way to detect the JNI registrations which is called,
+ // outside of OnJNIOnLoadRegisterJNI code path.
base::android::DisableManualJniRegistration();
- std::vector<base::android::RegisterCallback> register_callbacks;
- register_callbacks.push_back(base::Bind(&android_webview::RegisterJNI));
- std::vector<base::android::InitCallback> init_callbacks;
- init_callbacks.push_back(base::Bind(&android_webview::Init));
- if (!content::android::OnJNIOnLoadRegisterJNI(vm, register_callbacks) ||
- !content::android::OnJNIOnLoadInit(init_callbacks)) {
+ if (base::android::IsManualJniRegistrationDisabled()) {
+ base::android::InitVM(vm);
+ } else {
+ if (android_webview::OnJNIOnLoadRegisterJNI(vm))
+ return -1;
+ }
+
+ if (!android_webview::OnJNIOnLoadInit()) {
return -1;
}
return JNI_VERSION_1_4;
« no previous file with comments | « no previous file | android_webview/lib/main/webview_jni_onload.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698