Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: android_webview/lib/main/webview_entry_point.cc

Issue 975253002: refactoring Android Webview JNI_OnLoad interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove at exit manager change Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | android_webview/lib/main/webview_jni_onload.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/lib/main/webview_jni_onload.h" 5 #include "android_webview/lib/main/webview_jni_onload.h"
6 #include "base/android/jni_android.h" 6 #include "base/android/jni_android.h"
7 #include "base/bind.h"
8 #include "content/public/app/content_jni_onload.h"
9 7
10 // This is called by the VM when the shared library is first loaded. 8 // This is called by the VM when the shared library is first loaded.
11 // Most of the initialization is done in LibraryLoadedOnMainThread(), not here. 9 // Most of the initialization is done in LibraryLoadedOnMainThread(), not here.
12 JNI_EXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) { 10 JNI_EXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) {
13 // WebView uses native JNI exports; disable manual JNI registration to 11 // WebView uses native JNI exports; disable manual JNI registration because
14 // improve startup peformance. 12 // we don't have a good way to detect the JNI registrations which is called,
13 // outside of OnJNIOnLoadRegisterJNI code path.
15 base::android::DisableManualJniRegistration(); 14 base::android::DisableManualJniRegistration();
16 15
17 std::vector<base::android::RegisterCallback> register_callbacks; 16 if (base::android::IsManualJniRegistrationDisabled()) {
18 register_callbacks.push_back(base::Bind(&android_webview::RegisterJNI)); 17 base::android::InitVM(vm);
19 std::vector<base::android::InitCallback> init_callbacks; 18 } else {
20 init_callbacks.push_back(base::Bind(&android_webview::Init)); 19 if (android_webview::OnJNIOnLoadRegisterJNI(vm))
21 if (!content::android::OnJNIOnLoadRegisterJNI(vm, register_callbacks) || 20 return -1;
22 !content::android::OnJNIOnLoadInit(init_callbacks)) { 21 }
22
23 if (!android_webview::OnJNIOnLoadInit()) {
23 return -1; 24 return -1;
24 } 25 }
25 return JNI_VERSION_1_4; 26 return JNI_VERSION_1_4;
26 } 27 }
OLDNEW
« no previous file with comments | « no previous file | android_webview/lib/main/webview_jni_onload.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698