Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: android_webview/lib/main/webview_jni_onload.h

Issue 975253002: refactoring Android Webview JNI_OnLoad interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/lib/main/webview_jni_onload.h
diff --git a/android_webview/lib/main/webview_jni_onload.h b/android_webview/lib/main/webview_jni_onload.h
index 5805dd33e40cac65b21a51dac0360376990b6526..eb66f89a216caa4e058aa03048729014ccbf9eca 100644
--- a/android_webview/lib/main/webview_jni_onload.h
+++ b/android_webview/lib/main/webview_jni_onload.h
@@ -9,8 +9,12 @@
namespace android_webview {
-bool RegisterJNI(JNIEnv* env);
-bool Init();
+// This method shouldn't be used as WebView doesn't need JNI registration,
+// We didn't remove the JNI registration for comparing the performance between
Torne 2015/03/11 18:08:29 Replace this whole comment with "TODO(<you or me>)
michaelbai 2015/03/11 18:29:10 Done, but you told me that you still want it becau
+// JNI registration and native export.
+bool OnJNIOnLoadRegisterJNI(JavaVM* vm);
+
+bool OnJNIOnLoadInit();
} // android_webview

Powered by Google App Engine
This is Rietveld 408576698