android_webview/lib/main/webview_jni_onload.h - Issue 975253002: refactoring Android Webview JNI_OnLoad interface

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: android_webview/lib/main/webview_jni_onload.h

Issue 975253002: refactoring Android Webview JNI_OnLoad interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « android_webview/lib/main/webview_entry_point.cc ('k') | android_webview/lib/main/webview_jni_onload.cc » ('j') | base/android/library_loader/library_loader_hooks.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef ANDROID_WEBVIEW_LIB_MAIN_WEBVIEW_JNI_ONLOAD__H_	5 #ifndef ANDROID_WEBVIEW_LIB_MAIN_WEBVIEW_JNI_ONLOAD__H_

6 #define ANDROID_WEBVIEW_LIB_MAIN_WEBVIEW_JNI_ONLOAD__H_	6 #define ANDROID_WEBVIEW_LIB_MAIN_WEBVIEW_JNI_ONLOAD__H_

7	7

8 #include <jni.h>	8 #include <jni.h>

9	9

10 namespace android_webview {	10 namespace android_webview {

11	11

12 bool RegisterJNI(JNIEnv* env);	12 // This method shouldn't be used as WebView doesn't need JNI registration,

13 bool Init();	13 // We didn't remove the JNI registration for comparing the performance between
	Torne 2015/03/11 18:08:29 Replace this whole comment with "TODO(<you or me>) Replace this whole comment with "TODO(<you or me>): remove this once we no longer need to be able to run webview with manual JNI registration". There's not much point in explaining exactly what we are doing (especially as that's not all we are doing) michaelbai 2015/03/11 18:29:10 Done, but you told me that you still want it becau Show quoted text On 2015/03/11 18:08:29, Torne wrote: > Replace this whole comment with "TODO(<you or me>): remove this once we no > longer need to be able to run webview with manual JNI registration". There's not > much point in explaining exactly what we are doing (especially as that's not all > we are doing) Done, but you told me that you still want it because you want to comparing the performance. why it becomes "not all we are doing now"!
	14 // JNI registration and native export.

	15 bool OnJNIOnLoadRegisterJNI(JavaVM* vm);

	16

	17 bool OnJNIOnLoadInit();

14	18

15 } // android_webview	19 } // android_webview

16	20

17 #endif // ANDROID_WEBVIEW_LIB_MAIN_WEBVIEW_JNI_ONLOAD__H_	21 #endif // ANDROID_WEBVIEW_LIB_MAIN_WEBVIEW_JNI_ONLOAD__H_

OLD	NEW