mojo/common: Decouple GURL dependency

mojo/common/BUILD.gn

Index: mojo/common/BUILD.gn
diff --git a/mojo/common/BUILD.gn b/mojo/common/BUILD.gn
index ad01c318bb875d2428d6508c7cf2c4c4dd622fd4..0338198cdbbeb631a22955deed790de9b1e0f997 100644
--- a/mojo/common/BUILD.gn
+++ b/mojo/common/BUILD.gn
@@ -4,8 +4,15 @@
 
 import("//testing/test.gni")
 
+group("common") {
+  deps = [
+    ":common_base",
+    ":url_type_converters",
+  ]
+}
+
 # GYP version: mojo/mojo_base.gyp:mojo_common_lib
-component("common") {
+component("common_base") {
   output_name = "mojo_common_lib"
 
   sources = [
@@ -28,6 +35,19 @@ component("common") {
     "//base",
     "//base/third_party/dynamic_annotations",
     "//third_party/mojo/src/mojo/public/c/system:for_component",
+  ]
+}
+
+static_library("url_type_converters") {

[jamesr, 2015/03/04 04:14:44]

source_set

static_library is extremely rarely what you want in GN

document the name of the gyp equivalent

[Hajime Morrita, 2015/03/05 18:29:41]

Done.

+  sources = [
+    "url_type_converters.cc",
+    "url_type_converters.h",
+  ]
+
+  deps = [
+    "//base",
+    "//base/third_party/dynamic_annotations",
+    "//third_party/mojo/src/mojo/public/c/system:for_component",

[jamesr, 2015/03/04 04:14:44]

this is not a component so this is the wrong target to depend on

[Hajime Morrita, 2015/03/05 18:29:41]

Done.

     "//url",
   ]
 }
@@ -44,7 +64,6 @@ test("mojo_common_unittests") {
     "//third_party/mojo/src/mojo/edk/test:test_support",
     "//third_party/mojo/src/mojo/public/cpp/bindings",
     "//third_party/mojo/src/mojo/public/cpp/test_support:test_utils",
-    "//url",

[jamesr, 2015/03/04 04:14:44]

the test still appears to test url conversions - why is the dep removed? does
this pass gn check?

[Hajime Morrita, 2015/03/05 18:29:41]

Got it back and gn check passes now.

   ]
 
   sources = [