Issue 974613002: Revert of Autofill: Disable autofill for fields outside of forms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 974613002: Revert of Autofill: Disable autofill for fields outside of forms. (Closed)

Created:
5 years, 9 months ago by Lei Zhang

Modified:
5 years, 9 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, mlamouri+watch-content_chromium.org, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Autofill: Disable autofill for fields outside of forms. (patchset #2 id:10006 of https://codereview.chromium.org/964453004/) Reason for revert: CL merged to M41/M42. Re-enabling on trunk. Original issue's description: > Autofill: Disable autofill for fields outside of forms. > > BUG=462375 > > Committed: https://crrev.com/eb9e20d80c31c2842509e5213d4864eadf84baa1 > Cr-Commit-Position: refs/heads/master@{#318406} TBR=estade@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462375 Committed: https://crrev.com/92371967b3aa5266ea2e0783c8f51b651659556c Cr-Commit-Position: refs/heads/master@{#318783}

Patch Set 1 #

Created: 5 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -33 lines)			Patch
M	chrome/browser/autofill/form_structure_browsertest.cc	View	2 chunks	+1 line, -12 lines	0 comments	Download
M	chrome/renderer/autofill/autofill_renderer_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/autofill/form_autofill_browsertest.cc	View	18 chunks	+18 lines, -20 lines	0 comments	Download
M	components/autofill/content/renderer/form_cache.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	components/autofill/content/renderer/form_cache.cc	View	2 chunks	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

Created Revert of Autofill: Disable autofill for fields outside of forms.

5 years, 9 months ago (2015-03-02 22:36:51 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/974613002/1

5 years, 9 months ago (2015-03-02 22:41:43 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-02 22:43:38 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/92371967b3aa5266ea2e0783c8f51b651659556c
Cr-Commit-Position: refs/heads/master@{#318783}

Expand Messages | Collapse Messages