Revert of Autofill: Disable autofill for fields outside of forms.

chrome/renderer/autofill/form_autofill_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/format_macros.h"
 #include "base/strings/string16.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 2375 matching lines @@
       "  <INPUT type='text' id='firstname' value='John'/>"
       "  <INPUT type='text' id='lastname' value='Smith'/>"
       "  <INPUT type='text' id='email' value='john@example.com'"
       "autocomplete='off' />"
       "  <INPUT type='text' id='phone' value='1.800.555.1234'/>"
       "  <INPUT type='submit' name='reply-send' value='Send'/>"
       "</FORM>",
       false);
 }
 
-TEST_F(FormAutofillTest, DISABLED_FindFormForInputElementForUnownedForm) {
+TEST_F(FormAutofillTest, FindFormForInputElementForUnownedForm) {
     TestFindFormForInputElement(
         "<INPUT type='text' id='firstname' value='John'/>"
         "<INPUT type='text' id='lastname' value='Smith'/>"
         "<INPUT type='text' id='email' value='john@example.com'"
         "autocomplete='off' />"
         "<INPUT type='text' id='phone' value='1.800.555.1234'/>"
         "<INPUT type='submit' name='reply-send' value='Send'/>",
         true);
 }
 
 TEST_F(FormAutofillTest, FindFormForTextAreaElement) {
   TestFindFormForTextAreaElement(
       "<FORM name='TestForm' action='http://buh.com' method='post'>"
       "  <INPUT type='text' id='firstname' value='John'/>"
       "  <INPUT type='text' id='lastname' value='Smith'/>"
       "  <INPUT type='text' id='email' value='john@example.com'"
       "autocomplete='off' />"
       "  <TEXTAREA id='street-address'>"
       "123 Fantasy Ln.&#10;"
       "Apt. 42"
       "</TEXTAREA>"
       "  <INPUT type='submit' name='reply-send' value='Send'/>"
       "</FORM>",
       false);
 }
 
-TEST_F(FormAutofillTest, DISABLED_FindFormForTextAreaElementForUnownedForm) {
+TEST_F(FormAutofillTest, FindFormForTextAreaElementForUnownedForm) {
   TestFindFormForTextAreaElement(
       "<INPUT type='text' id='firstname' value='John'/>"
       "<INPUT type='text' id='lastname' value='Smith'/>"
       "<INPUT type='text' id='email' value='john@example.com'"
       "autocomplete='off' />"
       "<TEXTAREA id='street-address'>"
       "123 Fantasy Ln.&#10;"
       "Apt. 42"
       "</TEXTAREA>"
       "<INPUT type='submit' name='reply-send' value='Send'/>",
       true);
 }
 
 // Test regular FillForm function.
 TEST_F(FormAutofillTest, FillForm) {
   TestFillForm(kFormHtml, false);
 }
 
-TEST_F(FormAutofillTest, DISABLED_FillFormForUnownedForm) {
+TEST_F(FormAutofillTest, FillFormForUnownedForm) {
   TestFillForm(kUnownedFormHtml, true);
 }
 
 TEST_F(FormAutofillTest, FillFormIncludingNonFocusableElements) {
   static const AutofillFieldCase field_cases[] = {
       // fields: form_control_type, name, initial_value, autocomplete_attribute,
       //         should_be_autofilled, autofill_value, expected_value
 
       // Regular empty fields (firstname & lastname) should be autofilled.
       {"text",
@@ skipping 71 matching lines @@
   };
   TestFormFillFunctions(kFormHtml, false, field_cases, arraysize(field_cases),
                         &FillFormIncludingNonFocusableElementsWrapper,
                         &GetValueWrapper);
 }
 
 TEST_F(FormAutofillTest, PreviewForm) {
   TestPreviewForm(kFormHtml, false);
 }
 
-TEST_F(FormAutofillTest, DISABLED_PreviewFormForUnownedForm) {
+TEST_F(FormAutofillTest, PreviewFormForUnownedForm) {
   TestPreviewForm(kUnownedFormHtml, true);
 }
 
 TEST_F(FormAutofillTest, Labels) {
   ExpectJohnSmithLabels(
       "<FORM name='TestForm' action='http://cnn.com' method='post'>"
       "  <LABEL for='firstname'> First name: </LABEL>"
       "    <INPUT type='text' id='firstname' value='John'/>"
       "  <LABEL for='lastname'> Last name: </LABEL>"
       "    <INPUT type='text' id='lastname' value='Smith'/>"
@@ skipping 854 matching lines @@
   TestFillFormMaxLength(
       "<FORM name='TestForm' action='http://buh.com' method='post'>"
       "  <INPUT type='text' id='firstname' maxlength='5'/>"
       "  <INPUT type='text' id='lastname' maxlength='7'/>"
       "  <INPUT type='text' id='email' maxlength='9'/>"
       "  <INPUT type='submit' name='reply-send' value='Send'/>"
       "</FORM>",
       false);
 }
 
-TEST_F(FormAutofillTest, DISABLED_FillFormMaxLengthForUnownedForm) {
+TEST_F(FormAutofillTest, FillFormMaxLengthForUnownedForm) {
   TestFillFormMaxLength(
       "<INPUT type='text' id='firstname' maxlength='5'/>"
       "<INPUT type='text' id='lastname' maxlength='7'/>"
       "<INPUT type='text' id='email' maxlength='9'/>"
       "<INPUT type='submit' name='reply-send' value='Send'/>",
       true);
 }
 
 // This test uses negative values of the maxlength attribute for input elements.
 // In this case, the maxlength of the input elements is set to the default
 // maxlength (defined in WebKit.)
 TEST_F(FormAutofillTest, FillFormNegativeMaxLength) {
   TestFillFormNegativeMaxLength(
       "<FORM name='TestForm' action='http://buh.com' method='post'>"
       "  <INPUT type='text' id='firstname' maxlength='-1'/>"
       "  <INPUT type='text' id='lastname' maxlength='-10'/>"
       "  <INPUT type='text' id='email' maxlength='-13'/>"
       "  <INPUT type='submit' name='reply-send' value='Send'/>"
       "</FORM>",
       false);
 }
 
-TEST_F(FormAutofillTest, DISABLED_FillFormNegativeMaxLengthForUnownedForm) {
+TEST_F(FormAutofillTest, FillFormNegativeMaxLengthForUnownedForm) {
   TestFillFormNegativeMaxLength(
       "<INPUT type='text' id='firstname' maxlength='-1'/>"
       "<INPUT type='text' id='lastname' maxlength='-10'/>"
       "<INPUT type='text' id='email' maxlength='-13'/>"
       "<INPUT type='submit' name='reply-send' value='Send'/>",
       true);
 }
 
 TEST_F(FormAutofillTest, FillFormEmptyName) {
   TestFillFormEmptyName(
       "<FORM name='TestForm' action='http://buh.com' method='post'>"
       "  <INPUT type='text' id='firstname'/>"
       "  <INPUT type='text' id='lastname'/>"
       "  <INPUT type='text' id='email'/>"
       "  <INPUT type='submit' value='Send'/>"
       "</FORM>",
       false);
 }
 
-TEST_F(FormAutofillTest, DISABLED_FillFormEmptyNameForUnownedForm) {
+TEST_F(FormAutofillTest, FillFormEmptyNameForUnownedForm) {
   TestFillFormEmptyName(
       "<INPUT type='text' id='firstname'/>"
       "<INPUT type='text' id='lastname'/>"
       "<INPUT type='text' id='email'/>"
       "<INPUT type='submit' value='Send'/>",
       true);
 }
 
 TEST_F(FormAutofillTest, FillFormEmptyFormNames) {
   TestFillFormEmptyFormNames(
       "<FORM action='http://buh.com' method='post'>"
       "  <INPUT type='text' id='firstname'/>"
       "  <INPUT type='text' id='middlename'/>"
       "  <INPUT type='text' id='lastname'/>"
       "  <INPUT type='submit' value='Send'/>"
       "</FORM>"
       "<FORM action='http://abc.com' method='post'>"
       "  <INPUT type='text' id='apple'/>"
       "  <INPUT type='text' id='banana'/>"
       "  <INPUT type='text' id='cantelope'/>"
       "  <INPUT type='submit' value='Send'/>"
       "</FORM>",
       false);
 }
 
-TEST_F(FormAutofillTest, DISABLED_FillFormEmptyFormNamesForUnownedForm) {
+TEST_F(FormAutofillTest, FillFormEmptyFormNamesForUnownedForm) {
   TestFillFormEmptyFormNames(
       "<INPUT type='text' id='firstname'/>"
       "<INPUT type='text' id='middlename'/>"
       "<INPUT type='text' id='lastname'/>"
       "<INPUT type='text' id='apple'/>"
       "<INPUT type='text' id='banana'/>"
       "<INPUT type='text' id='cantelope'/>"
       "<INPUT type='submit' value='Send'/>",
       true);
 }
@@ skipping 135 matching lines @@
   TestFillFormNonEmptyField(
       "<FORM name='TestForm' action='http://buh.com' method='post'>"
       "  <INPUT type='text' id='firstname'/>"
       "  <INPUT type='text' id='lastname'/>"
       "  <INPUT type='text' id='email'/>"
       "  <INPUT type='submit' value='Send'/>"
       "</FORM>",
       false);
 }
 
-TEST_F(FormAutofillTest, DISABLED_FillFormNonEmptyFieldForUnownedForm) {
+TEST_F(FormAutofillTest, FillFormNonEmptyFieldForUnownedForm) {
   TestFillFormNonEmptyField("<INPUT type='text' id='firstname'/>"
                             "<INPUT type='text' id='lastname'/>"
                             "<INPUT type='text' id='email'/>"
                             "<INPUT type='submit' value='Send'/>",
                             true);
 }
 
 TEST_F(FormAutofillTest, ClearFormWithNode) {
   TestClearFormWithNode(
       "<FORM name='TestForm' action='http://buh.com' method='post'>"
       "  <INPUT type='text' id='firstname' value='Wyatt'/>"
       "  <INPUT type='text' id='lastname' value='Earp'/>"
       "  <INPUT type='text' autocomplete='off' id='noAC' value='one'/>"
       "  <INPUT type='text' id='notenabled' disabled='disabled'>"
       "  <INPUT type='month' id='month' value='2012-11'>"
       "  <INPUT type='month' id='month-disabled' value='2012-11'"
       "         disabled='disabled'>"
       "  <TEXTAREA id='textarea'>Apple.</TEXTAREA>"
       "  <TEXTAREA id='textarea-disabled' disabled='disabled'>"
       "    Banana!"
       "  </TEXTAREA>"
       "  <TEXTAREA id='textarea-noAC' autocomplete='off'>Carrot?</TEXTAREA>"
       "  <INPUT type='submit' value='Send'/>"
       "</FORM>",
       false);
 }
 
-TEST_F(FormAutofillTest, DISABLED_ClearFormWithNodeForUnownedForm) {
+TEST_F(FormAutofillTest, ClearFormWithNodeForUnownedForm) {
   TestClearFormWithNode(
       "  <!-- Indented on purpose //-->"
       "  <INPUT type='text' id='firstname' value='Wyatt'/>"
       "  <INPUT type='text' id='lastname' value='Earp'/>"
       "  <INPUT type='text' autocomplete='off' id='noAC' value='one'/>"
       "  <INPUT type='text' id='notenabled' disabled='disabled'>"
       "  <INPUT type='month' id='month' value='2012-11'>"
       "  <INPUT type='month' id='month-disabled' value='2012-11'"
       "         disabled='disabled'>"
       "  <TEXTAREA id='textarea'>Apple.</TEXTAREA>"
@@ skipping 14 matching lines @@
       "    <OPTION selected>?</OPTION>"
       "    <OPTION>AA</OPTION>"
       "    <OPTION>AE</OPTION>"
       "    <OPTION>AK</OPTION>"
       "  </SELECT>"
       "  <INPUT type='submit' value='Send'/>"
       "</FORM>",
       false);
 }
 
-TEST_F(FormAutofillTest,
-       DISABLED_ClearFormWithNodeContainingSelectOneForUnownedForm) {
+TEST_F(FormAutofillTest, ClearFormWithNodeContainingSelectOneForUnownedForm) {
   TestClearFormWithNodeContainingSelectOne(
       "<INPUT type='text' id='firstname' value='Wyatt'/>"
       "<INPUT type='text' id='lastname' value='Earp'/>"
       "<SELECT id='state' name='state'>"
       "  <OPTION selected>?</OPTION>"
       "  <OPTION>AA</OPTION>"
       "  <OPTION>AE</OPTION>"
       "  <OPTION>AK</OPTION>"
       "</SELECT>"
       "<INPUT type='submit' value='Send'/>",
       true);
 }
 
 TEST_F(FormAutofillTest, ClearPreviewedFormWithElement) {
   TestClearPreviewedFormWithElement(
       "<FORM name='TestForm' action='http://buh.com' method='post'>"
       "  <INPUT type='text' id='firstname' value='Wyatt'/>"
       "  <INPUT type='text' id='lastname'/>"
       "  <INPUT type='text' id='email'/>"
       "  <INPUT type='email' id='email2'/>"
       "  <INPUT type='tel' id='phone'/>"
       "  <INPUT type='submit' value='Send'/>"
       "</FORM>");
 }
 
-TEST_F(FormAutofillTest, DISABLED_ClearPreviewedFormWithElementForUnownedForm) {
+TEST_F(FormAutofillTest, ClearPreviewedFormWithElementForUnownedForm) {
   TestClearPreviewedFormWithElement(
       "<INPUT type='text' id='firstname' value='Wyatt'/>"
       "<INPUT type='text' id='lastname'/>"
       "<INPUT type='text' id='email'/>"
       "<INPUT type='email' id='email2'/>"
       "<INPUT type='tel' id='phone'/>"
       "<INPUT type='submit' value='Send'/>");
 }
 
 TEST_F(FormAutofillTest, ClearPreviewedFormWithNonEmptyInitiatingNode) {
   TestClearPreviewedFormWithNonEmptyInitiatingNode(
       "<FORM name='TestForm' action='http://buh.com' method='post'>"
       "  <INPUT type='text' id='firstname' value='W'/>"
       "  <INPUT type='text' id='lastname'/>"
       "  <INPUT type='text' id='email'/>"
       "  <INPUT type='email' id='email2'/>"
       "  <INPUT type='tel' id='phone'/>"
       "  <INPUT type='submit' value='Send'/>"
       "</FORM>");
 }
 
 TEST_F(FormAutofillTest,
-       DISABLED_ClearPreviewedFormWithNonEmptyInitiatingNodeForUnownedForm) {
+       ClearPreviewedFormWithNonEmptyInitiatingNodeForUnownedForm) {
   TestClearPreviewedFormWithNonEmptyInitiatingNode(
       "<INPUT type='text' id='firstname' value='W'/>"
       "<INPUT type='text' id='lastname'/>"
       "<INPUT type='text' id='email'/>"
       "<INPUT type='email' id='email2'/>"
       "<INPUT type='tel' id='phone'/>"
       "<INPUT type='submit' value='Send'/>");
 }
 
 TEST_F(FormAutofillTest, ClearPreviewedFormWithAutofilledInitiatingNode) {
   TestClearPreviewedFormWithAutofilledInitiatingNode(
       "<FORM name='TestForm' action='http://buh.com' method='post'>"
       "  <INPUT type='text' id='firstname' value='W'/>"
       "  <INPUT type='text' id='lastname'/>"
       "  <INPUT type='text' id='email'/>"
       "  <INPUT type='email' id='email2'/>"
       "  <INPUT type='tel' id='phone'/>"
       "  <INPUT type='submit' value='Send'/>"
       "</FORM>");
 }
 
 TEST_F(FormAutofillTest,
-       DISABLED_ClearPreviewedFormWithAutofilledInitiatingNodeForUnownedForm) {
+       ClearPreviewedFormWithAutofilledInitiatingNodeForUnownedForm) {
   TestClearPreviewedFormWithAutofilledInitiatingNode(
       "<INPUT type='text' id='firstname' value='W'/>"
       "<INPUT type='text' id='lastname'/>"
       "<INPUT type='text' id='email'/>"
       "<INPUT type='email' id='email2'/>"
       "<INPUT type='tel' id='phone'/>"
       "<INPUT type='submit' value='Send'/>");
 }
 
 // Autofill's "Clear Form" should clear only autofilled fields
 TEST_F(FormAutofillTest, ClearOnlyAutofilledFields) {
   TestClearOnlyAutofilledFields(
       "<FORM name='TestForm' action='http://buh.com' method='post'>"
       "  <INPUT type='text' id='firstname' value='Wyatt'/>"
       "  <INPUT type='text' id='lastname' value='Earp'/>"
       "  <INPUT type='email' id='email' value='wyatt@earp.com'/>"
       "  <INPUT type='tel' id='phone' value='650-777-9999'/>"
       "  <INPUT type='submit' value='Send'/>"
       "</FORM>");
 }
 
-TEST_F(FormAutofillTest, DISABLED_ClearOnlyAutofilledFieldsForUnownedForm) {
+TEST_F(FormAutofillTest, ClearOnlyAutofilledFieldsForUnownedForm) {
   TestClearOnlyAutofilledFields(
       "<INPUT type='text' id='firstname' value='Wyatt'/>"
       "<INPUT type='text' id='lastname' value='Earp'/>"
       "<INPUT type='email' id='email' value='wyatt@earp.com'/>"
       "<INPUT type='tel' id='phone' value='650-777-9999'/>"
       "<INPUT type='submit' value='Send'/>");
 }
 
 // If we have multiple labels per id, the labels concatenated into label string.
 TEST_F(FormAutofillTest, MultipleLabelsPerElement) {
@@ skipping 138 matching lines @@
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields[1]);
 
   expected.name = ASCIIToUTF16("country");
   expected.value = ASCIIToUTF16("AL");
   expected.form_control_type = "select-one";
   expected.max_length = 0;
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields[2]);
 }
 
 TEST_F(FormAutofillTest,
-       DISABLED_UnownedFormElementsAndFieldSetsToFormDataFieldsets) {
+       UnownedFormElementsAndFieldSetsToFormDataFieldsets) {
   std::vector<WebElement> fieldsets;
   std::vector<WebFormControlElement> control_elements;
 
   const ExtractMask extract_mask =
       static_cast<ExtractMask>(EXTRACT_VALUE | EXTRACT_OPTIONS);
   const GURL dummy_origin("http://www.example.com");
 
   LoadHTML("<DIV>"
            "  <FIELDSET>"
            "    <LABEL for='firstname'>First name:</LABEL>"
@@ skipping 41 matching lines @@
   expected.label = ASCIIToUTF16("Last name:");
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields[1]);
 
   expected.name = ASCIIToUTF16("email");
   expected.value = ASCIIToUTF16("john@example.com");
   expected.label = ASCIIToUTF16("Email:");
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields[2]);
 }
 
 TEST_F(FormAutofillTest,
-       DISABLED_UnownedFormElementsAndFieldSetsToFormDataControlOutsideOfFieldset) {
+       UnownedFormElementsAndFieldSetsToFormDataControlOutsideOfFieldset) {
   std::vector<WebElement> fieldsets;
   std::vector<WebFormControlElement> control_elements;
 
   const ExtractMask extract_mask =
       static_cast<ExtractMask>(EXTRACT_VALUE | EXTRACT_OPTIONS);
   const GURL dummy_origin("http://www.example.com");
 
   LoadHTML("<DIV>"
            "  <FIELDSET>"
            "    <LABEL for='firstname'>First name:</LABEL>"
@@ skipping 38 matching lines @@
   expected.value = ASCIIToUTF16("Smith");
   expected.label = ASCIIToUTF16("Last name:");
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields[1]);
 
   expected.name = ASCIIToUTF16("email");
   expected.value = ASCIIToUTF16("john@example.com");
   expected.label = ASCIIToUTF16("Email:");
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields[2]);
 }
 
-TEST_F(FormAutofillTest,
-       DISABLED_UnownedFormElementsAndFieldSetsToFormDataWithForm) {
+TEST_F(FormAutofillTest, UnownedFormElementsAndFieldSetsToFormDataWithForm) {
   std::vector<WebElement> fieldsets;
   std::vector<WebFormControlElement> control_elements;
 
   const ExtractMask extract_mask =
       static_cast<ExtractMask>(EXTRACT_VALUE | EXTRACT_OPTIONS);
   const GURL dummy_origin("http://www.example.com");
 
   LoadHTML(kFormHtml);
 
   WebFrame* frame = GetMainFrame();
   ASSERT_NE(nullptr, frame);
 
   control_elements = GetUnownedAutofillableFormFieldElements(
       frame->document().all(), &fieldsets);
   ASSERT_TRUE(control_elements.empty());
   ASSERT_TRUE(fieldsets.empty());
 
   FormData form;
   EXPECT_FALSE(UnownedFormElementsAndFieldSetsToFormData(
       fieldsets, control_elements, nullptr, dummy_origin, REQUIRE_NONE,
       extract_mask, &form, nullptr));
 }
 
 }  // namespace autofill