Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 974583002: Change to using an Ozone GLImage for VAAPI DRM video (Closed)

Created:
5 years, 9 months ago by achaulk
Modified:
5 years, 9 months ago
Reviewers:
Pawel Osciak, spang
CC:
chromium-reviews, ozone-reviews_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change to using an Ozone GLImage for VAAPI DRM video Clearing the pixmap in Destroy fixes the apparent allocation ordering issues BUG=370522 TEST=~15 minutes of HD youtube video on link with size changes between 360p, 480p, 720p, usually this would fail immediately Committed: https://crrev.com/66a57415c82a36e528c1ef32d9e1fc783f5c18d4 Cr-Commit-Position: refs/heads/master@{#319900}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M content/common/gpu/media/vaapi_drm_picture.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/gpu/media/vaapi_drm_picture.cc View 1 chunk +6 lines, -9 lines 0 comments Download
M ui/ozone/gpu/gpu_memory_buffer_factory_ozone_native_buffer.cc View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
achaulk
5 years, 9 months ago (2015-03-02 21:28:08 UTC) #2
Pawel Osciak
On 2015/03/02 21:28:08, achaulk wrote: content/common/gpu/media lgtm Is there a BUG= for this? Which platform ...
5 years, 9 months ago (2015-03-03 09:14:15 UTC) #3
achaulk
Bug added. I was using youtube, switching between 360, 480 and 720p streams on a ...
5 years, 9 months ago (2015-03-03 18:12:53 UTC) #4
achaulk
Platform was link
5 years, 9 months ago (2015-03-03 18:13:21 UTC) #5
spang
On 2015/03/03 18:12:53, achaulk wrote: > Bug added. I was using youtube, switching between 360, ...
5 years, 9 months ago (2015-03-03 19:09:50 UTC) #6
achaulk
description changed
5 years, 9 months ago (2015-03-09 17:41:02 UTC) #7
spang
lgtm
5 years, 9 months ago (2015-03-10 16:09:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/974583002/1
5 years, 9 months ago (2015-03-10 16:10:21 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 16:43:39 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 16:44:27 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66a57415c82a36e528c1ef32d9e1fc783f5c18d4
Cr-Commit-Position: refs/heads/master@{#319900}

Powered by Google App Engine
This is Rietveld 408576698