Chromium Code Reviews

Issue 974543002: Remove link_chrome_on_windows GN flag. (Closed)

Created:
5 years, 9 months ago by brettw
Modified:
5 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, mlamouri+watch-content_chromium.org, sadrul, extensions-reviews_chromium.org, peter+watch_chromium.org, tfarina, mlamouri+watch-notifications_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, kalyank, cc-bugs_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove link_chrome_on_windows GN flag. This flag was used to disable linking when the bots were too behind. It's not needed any more. Committed: https://crrev.com/4897a61fd022efb0b43033846fe878a351c55b35 Cr-Commit-Position: refs/heads/master@{#318795}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Stats (+934 lines, -976 lines)
M ash/BUILD.gn View 1 chunk +34 lines, -36 lines 0 comments
M build/config/BUILDCONFIG.gn View 1 chunk +0 lines, -5 lines 0 comments
M cc/BUILD.gn View 1 chunk +150 lines, -152 lines 0 comments
M cc/blink/BUILD.gn View 1 chunk +1 line, -1 line 0 comments
M chrome/BUILD.gn View 2 chunks +71 lines, -82 lines 0 comments
M chrome/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments
M components/BUILD.gn View 1 chunk +73 lines, -75 lines 0 comments
M content/shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments
M content/test/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments
M extensions/shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments
M google_apis/BUILD.gn View 1 chunk +35 lines, -37 lines 0 comments
M gpu/BUILD.gn View 1 chunk +202 lines, -204 lines 0 comments
M media/blink/BUILD.gn View 1 chunk +1 line, -1 line 0 comments
M ui/app_list/BUILD.gn View 1 chunk +58 lines, -60 lines 0 comments
M ui/aura/BUILD.gn View 1 chunk +49 lines, -51 lines 0 comments
M ui/keyboard/BUILD.gn View 1 chunk +26 lines, -28 lines 0 comments
M ui/message_center/BUILD.gn View 1 chunk +54 lines, -56 lines 0 comments
M ui/snapshot/BUILD.gn View 1 chunk +27 lines, -29 lines 0 comments
M ui/views/BUILD.gn View 1 chunk +88 lines, -90 lines 0 comments
M ui/views/examples/BUILD.gn View 1 chunk +27 lines, -29 lines 0 comments
M ui/wm/BUILD.gn View 1 chunk +32 lines, -34 lines 0 comments

Messages

Total messages: 13 (4 generated)
brettw
This should be just removing the conditionals and re-indenting, although it seems reitveld is making ...
5 years, 9 months ago (2015-03-02 19:24:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/974543002/20001
5 years, 9 months ago (2015-03-02 20:31:49 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-02 20:31:53 UTC) #6
jam
win8_chromium_gn_rel has a median cycle time of 46 minutes. is that because it's only running ...
5 years, 9 months ago (2015-03-02 22:31:12 UTC) #7
brettw
This flag is currently set to true. This is a NO-OP cleanup patch.
5 years, 9 months ago (2015-03-02 22:40:34 UTC) #8
jam
On 2015/03/02 22:40:34, brettw wrote: > This flag is currently set to true. This is ...
5 years, 9 months ago (2015-03-02 23:02:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/974543002/20001
5 years, 9 months ago (2015-03-02 23:10:18 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-02 23:13:25 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 23:13:54 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4897a61fd022efb0b43033846fe878a351c55b35
Cr-Commit-Position: refs/heads/master@{#318795}

Powered by Google App Engine