build/config/BUILDCONFIG.gn - Issue 974543002: Remove link_chrome_on_windows GN flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/BUILDCONFIG.gn

Issue 974543002: Remove link_chrome_on_windows GN flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/BUILDCONFIG.gn

diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn

index 7c06e5934c8c53a569df09179c8bfa5f0cd62ac5..3afba8921f01609493aecbdf66c17aade9f32f39 100644

--- a/build/config/BUILDCONFIG.gn

+++ b/build/config/BUILDCONFIG.gn

@@ -113,11 +113,6 @@ declare_args() {

# toolchains.

cros_use_custom_toolchain = false

}

- # TODO(brettw) remove this flag (and therefore enable linking all targets) on

- # Windows when we have sufficient bot capacity. In the meantime, you can

- # enable linking for local compiles.

- link_chrome_on_windows = true

}

# TODO(dpranke): Remove these asserts when os and cpu_arch are removed.

« no previous file with comments | « ash/BUILD.gn ('k') | cc/BUILD.gn » ('j') | no next file with comments »