chrome/browser/ui/BUILD.gn - Issue 974323002: Componentize autofill dialog common code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/BUILD.gn

Issue 974323002: Componentize autofill dialog common code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/android/autofill/autofill_dialog_controller_android.h » ('j') | chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/BUILD.gn

diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn

index 538f50aabacd76ca0e8f3aafcc436061fdf6ba35..414174e7de19b6572bb3865a0ead708384ff22d6 100644

--- a/chrome/browser/ui/BUILD.gn

+++ b/chrome/browser/ui/BUILD.gn

@@ -46,6 +46,7 @@ static_library("ui") {

"//chrome/common/net",

"//components/app_modal",

"//components/auto_login_parser",

+ "//components/autofill/core/browser",

"//components/dom_distiller/webui",

"//components/feedback/proto",

"//components/history/core/browser:proto",

@@ -420,21 +421,15 @@ static_library("ui") {

".",

"//chrome")

}

- if (enable_autofill_dialog) {

- sources +=

- rebase_path(gypi_values.chrome_browser_ui_autofill_dialog_sources,

- ".",

- "//chrome")

- if (!is_android && !is_ios) {

- sources += rebase_path(

- gypi_values.chrome_browser_ui_autofill_dialog_non_mobile_sources,

- ".",

- "//chrome")

- deps += [

- "//third_party/libaddressinput",

- "//third_party/libaddressinput:strings",

- ]

- }

+ if (enable_autofill_dialog && !is_android && !is_ios) {

+ sources += rebase_path(

+ gypi_values.chrome_browser_ui_autofill_dialog_non_mobile_sources,

+ ".",

+ "//chrome")

+ deps += [

+ "//third_party/libaddressinput",

+ "//third_party/libaddressinput:strings",

+ ]

}

if (enable_extensions) {

deps += [