chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc - Issue 974323002: Componentize autofill dialog common code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc

Issue 974323002: Componentize autofill dialog common code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/autofill/autofill_dialog_controller_android.h ('k') | chrome/browser/ui/autofill/autofill_dialog_common.h » ('j') | chrome/browser/ui/autofill/autofill_dialog_types.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc

diff --git a/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc b/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc

index 90a01157faf42cc7c7335611773d43e88242505f..cd15cdf360a96ad31a96ba167077ef2b556c8a5a 100644

--- a/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc

+++ b/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc

@@ -19,7 +19,6 @@

#include "chrome/browser/profiles/profile_manager.h"

#include "chrome/browser/ui/android/autofill/autofill_dialog_result.h"

#include "chrome/browser/ui/android/window_android_helper.h"

-#include "chrome/browser/ui/autofill/autofill_dialog_common.h"

Evan Stade 2015/03/05 02:28:59 this actually isn't used

droger 2015/03/05 09:04:57 I cannot remove it, common::BuildInputs() is used

#include "chrome/common/pref_names.h"

#include "chrome/common/url_constants.h"

#include "components/autofill/content/browser/wallet/full_wallet.h"

@@ -28,6 +27,7 @@

#include "components/autofill/core/browser/autofill_type.h"

#include "components/autofill/core/browser/credit_card.h"

#include "components/autofill/core/browser/personal_data_manager.h"

+#include "components/autofill/core/browser/ui/autofill_dialog_common.h"

#include "components/autofill/core/common/form_data.h"

#include "components/pref_registry/pref_registry_syncable.h"

#include "content/public/browser/navigation_controller.h"