Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 974273003: Revert "Revert "Support multiple DOM isolates and tweak devtools frontend to better handle large #s… (Closed)

Created:
5 years, 9 months ago by Jacob
Modified:
5 years, 9 months ago
Reviewers:
vsm
CC:
reviews+dom_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Revert "Revert "Support multiple DOM isolates and tweak devtools frontend to better handle large #s of libraries with long library names."" This reverts commit 10a52bd412720bb1f58d03813beb7c6576e6d6b5. BUG= Committed: https://src.chromium.org/viewvc/blink/branches/dart/dartium?view=rev&revision=191296

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -111 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/dart/Multiscript.dart View 1 chunk +14 lines, -12 lines 0 comments Download
M LayoutTests/dart/Multiscript.html View 2 chunks +71 lines, -11 lines 0 comments Download
M LayoutTests/dart/Multiscript-expected.txt View 1 chunk +4 lines, -24 lines 0 comments Download
M LayoutTests/dart/reload-crash-two-isolates-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/core/dart/DartApplicationLoader.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/core/dart/DartController.h View 1 chunk +7 lines, -3 lines 0 comments Download
M Source/bindings/core/dart/DartController.cpp View 5 chunks +54 lines, -44 lines 0 comments Download
M Source/bindings/core/dart/DartJsInterop.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M Source/bindings/core/dart/DartScriptState.h View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/core/dart/DartScriptState.cpp View 1 chunk +7 lines, -2 lines 0 comments Download
M Source/devtools/front_end/console/ConsoleView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/inspectorStyle.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sdk/RuntimeModel.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
Jacob
revert the revert. Have a matching dart CL lgtmed that fixes the dart/html test failures ...
5 years, 9 months ago (2015-03-04 17:22:45 UTC) #2
Jacob
5 years, 9 months ago (2015-03-04 17:23:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 191296.

Powered by Google App Engine
This is Rietveld 408576698