Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: Source/bindings/core/dart/DartScriptState.h

Issue 974273003: Revert "Revert "Support multiple DOM isolates and tweak devtools frontend to better handle large #s… (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/dartium
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/dart/DartJsInterop.cpp ('k') | Source/bindings/core/dart/DartScriptState.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/dart/DartScriptState.h
diff --git a/Source/bindings/core/dart/DartScriptState.h b/Source/bindings/core/dart/DartScriptState.h
index 5ab92f79fd2d3004d592d3d0095d99400398c011..033547d1ceec28641645383fdf8357ea3568cd2c 100644
--- a/Source/bindings/core/dart/DartScriptState.h
+++ b/Source/bindings/core/dart/DartScriptState.h
@@ -40,15 +40,15 @@ namespace blink {
class DartScriptState : public ScriptState {
WTF_MAKE_NONCOPYABLE(DartScriptState);
public:
- static PassRefPtr<DartScriptState> create(Dart_Isolate isolate, intptr_t libraryId, V8ScriptState* v8ScriptState)
+ static PassRefPtr<DartScriptState> create(Dart_Isolate isolate, intptr_t libraryId, V8ScriptState* v8ScriptState, const String& isolateName)
{
- return adoptRef(new DartScriptState(isolate, libraryId, v8ScriptState));
+ return adoptRef(new DartScriptState(isolate, libraryId, v8ScriptState, isolateName));
}
// Long term we want to be creating DartScriptStates without V8ScriptStates.
- static PassRefPtr<DartScriptState> create(Dart_Isolate isolate, intptr_t libraryId)
+ static PassRefPtr<DartScriptState> create(Dart_Isolate isolate, intptr_t libraryId, const String& isolateName)
{
- return adoptRef(new DartScriptState(isolate, libraryId, 0));
+ return adoptRef(new DartScriptState(isolate, libraryId, 0, isolateName));
}
bool isDartScriptState() const { return true; }
@@ -87,7 +87,7 @@ public:
Dart_Isolate isolate() { return m_isolate; }
virtual intptr_t libraryId() { return m_libraryId; }
- virtual const String* name() { return &m_libraryUrl; }
+ virtual const String* name() { return &m_name; }
virtual bool isJavaScript() { return false; }
#ifndef NDEBUG
@@ -95,12 +95,12 @@ public:
#endif
private:
- explicit DartScriptState(Dart_Isolate, intptr_t libraryId, V8ScriptState*);
+ explicit DartScriptState(Dart_Isolate, intptr_t libraryId, V8ScriptState*, const String& isolateName);
~DartScriptState() { }
Dart_Isolate m_isolate;
intptr_t m_libraryId;
- String m_libraryUrl;
+ String m_name;
RefPtr<V8ScriptState> m_v8ScriptState;
};
« no previous file with comments | « Source/bindings/core/dart/DartJsInterop.cpp ('k') | Source/bindings/core/dart/DartScriptState.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698