Chromium Code Reviews| Index: pydir/run-pnacl-sz.py |
| diff --git a/pydir/run-pnacl-sz.py b/pydir/run-pnacl-sz.py |
| index 65eb22bf70c10436f9b2b7eba409240c6354ee48..ed320ee42d303052c4f42686b18a9e56df492aa2 100755 |
| --- a/pydir/run-pnacl-sz.py |
| +++ b/pydir/run-pnacl-sz.py |
| @@ -112,7 +112,8 @@ def main(): |
| asm_temp.close() |
| if args.assemble and args.filetype != 'obj': |
| cmd += ['|', os.path.join(llvm_bin_path, 'llvm-mc'), |
| - '-triple=i686-none-nacl', |
| + # TODO(stichnot): use i686-nacl? |
|
jvoung (off chromium)
2015/03/03 22:58:02
What are the issues with deciding between i686 or
Jim Stichnoth
2015/03/03 23:18:51
If we are testing low-level aspects of sandboxing,
jvoung (off chromium)
2015/03/03 23:52:53
Yeah I think clarify in the TODO to choose between
Jim Stichnoth
2015/03/04 00:12:58
Done.
|
| + '-triple=i686', |
| '-filetype=obj', '-o', asm_temp.name] |
| elif asm_temp: |
| cmd += ['-o', asm_temp.name] |