Subzero: Run sandboxed cross tests, and do some cleanup.

pydir/run-pnacl-sz.py

 #!/usr/bin/env python2
 
 import argparse
 import itertools
 import os
 import re
 import subprocess
 import sys
 import tempfile
 
@@ skipping 94 matching lines @@
       cmd += [llfile]
     asm_temp = None
     if args.assemble or args.disassemble:
       # On windows we may need to close the file first before it can be
       # re-opened by the other tools, so don't do delete-on-close,
       # and instead manually delete.
       asm_temp = tempfile.NamedTemporaryFile(delete=False)
       asm_temp.close()
     if args.assemble and args.filetype != 'obj':
       cmd += ['|', os.path.join(llvm_bin_path, 'llvm-mc'),
-              '-triple=i686-none-nacl',
+              # TODO(stichnot): use i686-nacl?

[jvoung (off chromium), 2015/03/03 22:58:02]

What are the issues with deciding between i686 or i686-nacl?

[Jim Stichnoth, 2015/03/03 23:18:51]

If we are testing low-level aspects of sandboxing, and use --assemble, we would
probably want to use -triple=i686-nacl.  Maybe the TODO should say to add a
--sandbox argument and then select between i686 and i686-nacl?  Thoughts?

[jvoung (off chromium), 2015/03/03 23:52:53]

Yeah I think clarify in the TODO to choose between i686 and i686-nacl if
sandboxing is being tested or not?

[Jim Stichnoth, 2015/03/04 00:12:58]

Done.

+              '-triple=i686',
               '-filetype=obj', '-o', asm_temp.name]
     elif asm_temp:
       cmd += ['-o', asm_temp.name]
     if args.disassemble:
       # Show wide instruction encodings, diassemble, and show relocs.
       cmd += (['&&', os.path.join(binutils_bin_path, 'objdump')] +
               args.dis_flags +
               ['-w', '-d', '-r', '-Mintel', asm_temp.name])
 
     stdout_result = shellcmd(cmd, echo=args.echo_cmd)
     if not args.echo_cmd:
       sys.stdout.write(stdout_result)
     if asm_temp:
       os.remove(asm_temp.name)
 
 if __name__ == '__main__':
     main()