Issue 973823002: Check in pnglibconf.h so we don't need to generate it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 973823002: Check in pnglibconf.h so we don't need to generate it. (Closed)

Created:
5 years, 9 months ago by scroggo

Modified:
5 years, 9 months ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@pngCodecFinalIHope_2

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Check in pnglibconf.h so we don't need to generate it. Generating it apparently requires a race, so just check it in. Builds on https://codereview.chromium.org/930283002/ (DIFFERENT ISSUE). Also includes https://codereview.chromium.org/964293003/ (DIFFERENT ISSUE), which builds and links libpng as a static library everywhere except for the Android framework.

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+409 lines, -65 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	gyp/common_variables.gypi	View	2 chunks	+6 lines, -10 lines	0 comments	Download
D	gyp/copy_file.py	View	1 chunk	+0 lines, -39 lines	0 comments	Download
M	gyp/libpng.gyp	View	3 chunks	+4 lines, -16 lines	0 comments	Download
A	third_party/libpng/LICENSE	View	1 chunk	+172 lines, -0 lines	0 comments	Download
A	third_party/libpng/README.google	View	1 chunk	+16 lines, -0 lines	0 comments	Download
A	third_party/libpng/pnglibconf.h	View	1 chunk	+210 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scroggo

5 years, 9 months ago (2015-03-03 18:42:33 UTC) #2

Message was sent while issue was closed.

On 2015/03/03 16:22:59, scroggo wrote:
> Patchset #2 (id:20001) has been deleted

Pulled into https://codereview.chromium.org/930283002/

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages