third_party/libpng/README.google - Issue 973823002: Check in pnglibconf.h so we don't need to generate it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libpng/README.google

Issue 973823002: Check in pnglibconf.h so we don't need to generate it. (Closed) Base URL: https://skia.googlesource.com/skia.git@pngCodecFinalIHope_2

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/libpng/README.google

diff --git a/third_party/libpng/README.google b/third_party/libpng/README.google

new file mode 100644

index 0000000000000000000000000000000000000000..6453550aa244be2e9dddaf7bd945c341cb3e63ab

--- /dev/null

+++ b/third_party/libpng/README.google

@@ -0,0 +1,16 @@

+URL: http://www.libpng.org/pub/png/libpng.html

+Version: 1.6.16

+License: libpng license

+License File: LICENSE, pulled out of png.h

+Description: png compression/decompression library

+Local Modifications: Created pnglibconf.h from pnglibconf.dfa (just a rename).

+ Pulled LICENSE into its own file.

+FAQ:

+Q: Why does this directory exist?

+A: libpng is pulled in through DEPS, but in order to build it using ninja, we

+ need to create pnglibconf.h. In https://codereview.chromium.org/930283002/,

+ we originally tried creating the file as an action, but this apparently led

+ to a race condition on Windows, where some builds failed to create the file

+ in time for other files to include it. By checking pnglibconf.h directly

+ into Skia, we eliminate the race condition.

« no previous file with comments | « third_party/libpng/LICENSE ('k') | third_party/libpng/pnglibconf.h » ('j') | no next file with comments »