Source/core/css/parser/CSSParserValues.cpp - Issue 973623002: Fix serialization of content property to always quote

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSParserValues.cpp

Issue 973623002: Fix serialization of content property to always quote (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix charset test Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/css/parser/CSSGrammar.y ('K') | « Source/core/css/parser/CSSGrammar.y ('k') | Source/core/css/parser/CSSPropertyParser.h » ('j') | Source/core/css/parser/CSSPropertyParser.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/parser/CSSParserValues.cpp

diff --git a/Source/core/css/parser/CSSParserValues.cpp b/Source/core/css/parser/CSSParserValues.cpp

index a18e454d7139bf65508c8afec4b872597ecc2cfe..714cbefdda7bdabb206ccd75c29e3dc15280cc04 100644

--- a/Source/core/css/parser/CSSParserValues.cpp

+++ b/Source/core/css/parser/CSSParserValues.cpp

@@ -177,7 +177,7 @@ CSSParserValueList::CSSParserValueList(CSSParserTokenRange range)

if (token.type() == HashToken)

value.unit = CSSParserValue::HexColor;

else if (token.type() == StringToken)

- value.unit = CSSPrimitiveValue::CSS_STRING;

+ value.unit = CSSPrimitiveValue::CSS_CUSTOM_IDENT;

Timothy Loh 2015/03/03 23:20:15 These should also stay as <string>

else if (token.type() == UnicodeRangeToken)

value.unit = CSSPrimitiveValue::CSS_UNICODE_RANGE;

else

« Source/core/css/parser/CSSGrammar.y ('K') | « Source/core/css/parser/CSSGrammar.y ('k') | Source/core/css/parser/CSSPropertyParser.h » ('j') | Source/core/css/parser/CSSPropertyParser.h » ('J')