Source/core/css/parser/CSSGrammar.y - Issue 973623002: Fix serialization of content property to always quote

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSGrammar.y

Issue 973623002: Fix serialization of content property to always quote (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix charset test Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/css/CSSValuePool.cpp ('K') | « Source/core/css/StylePropertySerializer.cpp ('k') | Source/core/css/parser/CSSParserValues.cpp » ('j') | Source/core/css/parser/CSSParserValues.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/parser/CSSGrammar.y

diff --git a/Source/core/css/parser/CSSGrammar.y b/Source/core/css/parser/CSSGrammar.y

index f1d7c559ae1398298782d4a327e1ac2c56d7a46f..fd50e951518b9d5a4e872a3ff1a9e73261588e77 100644

--- a/Source/core/css/parser/CSSGrammar.y

+++ b/Source/core/css/parser/CSSGrammar.y

@@ -1627,7 +1627,7 @@ operator:

term:

unary_term maybe_space

| unary_operator unary_term maybe_space { $$ = $2; $$.fValue *= $1; }

- | STRING maybe_space { $$.id = CSSValueInvalid; $$.isInt = false; $$.string = $1; $$.unit = CSSPrimitiveValue::CSS_STRING; }

+ | STRING maybe_space { $$.id = CSSValueInvalid; $$.isInt = false; $$.string = $1; $$.unit = CSSPrimitiveValue::CSS_CUSTOM_IDENT; }

Timothy Loh 2015/03/03 23:20:15 These are still <string>s though, right?

| IDENT maybe_space { $$ = makeIdentValue($1); }

/* We might need to actually parse the number from a dimension, but we can't just put something that uses $$.string into unary_term. */

| DIMEN maybe_space { $$.id = CSSValueInvalid; $$.string = $1; $$.isInt = false; $$.unit = CSSParserValue::Dimension; }