Source/core/css/CSSValuePool.cpp - Issue 973623002: Fix serialization of content property to always quote

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSValuePool.cpp

Issue 973623002: Fix serialization of content property to always quote (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix charset test Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSValuePool.cpp

diff --git a/Source/core/css/CSSValuePool.cpp b/Source/core/css/CSSValuePool.cpp

index bd6950eeb9b2978f879650b0fc182dd303707265..a7976602416703379594ab3ef0be9c6aeea3edb4 100644

--- a/Source/core/css/CSSValuePool.cpp

+++ b/Source/core/css/CSSValuePool.cpp

@@ -130,7 +130,7 @@ PassRefPtrWillBeRawPtr<CSSPrimitiveValue> CSSValuePool::createFontFamilyValue(co

{

RefPtrWillBeMember<CSSPrimitiveValue>& value = m_fontFamilyValueCache.add(familyName, nullptr).storedValue->value;

if (!value)

- value = CSSPrimitiveValue::create(familyName, CSSPrimitiveValue::CSS_STRING);

+ value = CSSPrimitiveValue::create(familyName, CSSPrimitiveValue::CSS_CUSTOM_IDENT);

Timothy Loh 2015/03/03 23:20:15 probably still CSS_STRING

return value;

}

« no previous file with comments | « Source/core/css/CSSValueList.cpp ('k') | Source/core/css/LayoutStyleCSSValueMapping.cpp » ('j') | Source/core/css/parser/CSSGrammar.y » ('J')