Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Issue 973123003: Ensure that pointer lock works correctly in Windows 7+ with HiDPI scale factors above 1 (Closed)

Created:
5 years, 9 months ago by ananta
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jdduke+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure that pointer lock works correctly in Windows 7+ with HiDPI scale factors above 1 We were not scaling the mouse coordinate by the scale factor before invoking the ClientToScreen API. With this change the blink::WebMouseEvent.globalX and globalY values have to be converted back to DIP after convering them to screen. This should fix the mouse locking issue. BUG=411634 TEST= The main test case in bug 411634 Committed: https://crrev.com/05f7888960f6e3393b2ad5f5835028404737c584 Cr-Commit-Position: refs/heads/master@{#319181}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M content/browser/renderer_host/input/web_input_event_builders_win.cc View 2 chunks +17 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ananta
5 years, 9 months ago (2015-03-04 02:59:44 UTC) #2
scheib
Thanks, LGTM with one item: Please add a TEST= line to the change description, probably ...
5 years, 9 months ago (2015-03-04 05:14:19 UTC) #3
ananta
+cpu for owners
5 years, 9 months ago (2015-03-04 20:21:32 UTC) #5
cpu_(ooo_6.6-7.5)
lgtm
5 years, 9 months ago (2015-03-05 00:54:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/973123003/1
5 years, 9 months ago (2015-03-05 00:55:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-05 01:01:57 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 01:03:08 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05f7888960f6e3393b2ad5f5835028404737c584
Cr-Commit-Position: refs/heads/master@{#319181}

Powered by Google App Engine
This is Rietveld 408576698