Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 973103003: Revert of Rename WorkerPermissionClient and friends to WorkerContentSettingsClient. (Closed)

Created:
5 years, 9 months ago by enne (OOO)
Modified:
5 years, 9 months ago
CC:
blink-reviews, dglazkov+blink, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Rename WorkerPermissionClient and friends to WorkerContentSettingsClient. (patchset #1 id:1 of https://codereview.chromium.org/968163003/) Reason for revert: Likely causing browser_test crashes See: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/42911/steps/browser_tests/logs/WebViewTest.FileSystemAPIRequestFromWorkerDeny ../../chrome/browser/apps/guest_view/web_view_browsertest.cc:621: Failure Value of: done_listener.WaitUntilSatisfied() Actual: false Expected: true Original issue's description: > Rename WorkerPermissionClient and friends to WorkerContentSettingsClient. > > This CL is keeping WebWorkerPermissionClient and its proxy alive to prevent > Chromium build to break. > > This is part of a suite of three CLs: > 1. <this> > 2. https://codereview.chromium.org/968983002 > 3. https://codereview.chromium.org/968203002 > > BUG=462255 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191193 TBR=jochen@chromium.org,mlamouri@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462255 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191203

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -238 lines) Patch
M Source/web/IndexedDBClientImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/LocalFileSystemClient.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/web/WebSharedWorkerImpl.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
D Source/web/WorkerContentSettingsClient.h View 1 chunk +0 lines, -67 lines 0 comments Download
D Source/web/WorkerContentSettingsClient.cpp View 1 chunk +0 lines, -88 lines 0 comments Download
M Source/web/WorkerGlobalScopeProxyProviderImpl.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
A Source/web/WorkerPermissionClient.h View 1 chunk +67 lines, -0 lines 0 comments Download
A Source/web/WorkerPermissionClient.cpp View 1 chunk +88 lines, -0 lines 0 comments Download
M Source/web/web.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M public/web/WebEmbeddedWorker.h View 2 chunks +4 lines, -4 lines 0 comments Download
M public/web/WebFrameClient.h View 2 chunks +2 lines, -3 lines 0 comments Download
M public/web/WebServiceWorkerContextClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M public/web/WebSharedWorkerClient.h View 3 chunks +3 lines, -9 lines 0 comments Download
D public/web/WebWorkerContentSettingsClientProxy.h View 1 chunk +0 lines, -43 lines 0 comments Download
M public/web/WebWorkerPermissionClientProxy.h View 1 chunk +27 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
enne (OOO)
Created Revert of Rename WorkerPermissionClient and friends to WorkerContentSettingsClient.
5 years, 9 months ago (2015-03-03 18:06:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/973103003/1
5 years, 9 months ago (2015-03-03 18:07:40 UTC) #2
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 18:08:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191203

Powered by Google App Engine
This is Rietveld 408576698