Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 968983002: Rename blink::WebWorkerPermissionProxyClient to blink::WebWorkerContentSettingsProxyClient. (Closed)

Created:
5 years, 9 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, kinuko+watch, mkwst+moarreviews-renderer_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename blink::WebWorkerPermissionProxyClient to blink::WebWorkerContentSettingsProxyClient. This is part of a suite of thee CLs: 1. https://codereview.chromium.org/968163003 2. <this> 3. https://codereview.chromium.org/968203002 BUG=462255 Committed: https://crrev.com/a5b2945517b18dd86a56fbd922fd8a9ce829f5fc Cr-Commit-Position: refs/heads/master@{#319647}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix gypi typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -288 lines) Patch
M chrome/chrome_renderer.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/renderer/worker_content_settings_client_proxy.h View 3 chunks +10 lines, -10 lines 0 comments Download
A + chrome/renderer/worker_content_settings_client_proxy.cc View 5 chunks +7 lines, -6 lines 0 comments Download
D chrome/renderer/worker_permission_client_proxy.h View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/renderer/worker_permission_client_proxy.cc View 1 chunk +0 lines, -64 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/renderer/content_renderer_client.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/public/renderer/content_renderer_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/renderer/shared_worker/embedded_shared_worker_content_settings_client_proxy.h View 3 chunks +10 lines, -10 lines 0 comments Download
A + content/renderer/shared_worker/embedded_shared_worker_content_settings_client_proxy.cc View 5 chunks +9 lines, -8 lines 0 comments Download
D content/renderer/shared_worker/embedded_shared_worker_permission_client_proxy.h View 1 chunk +0 lines, -47 lines 0 comments Download
D content/renderer/shared_worker/embedded_shared_worker_permission_client_proxy.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M content/renderer/shared_worker/embedded_shared_worker_stub.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/shared_worker/embedded_shared_worker_stub.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
mlamouri (slow - plz ping)
5 years, 9 months ago (2015-03-02 15:24:01 UTC) #2
jochen (gone - plz use gerrit)
lgtm assuming consistent naming https://codereview.chromium.org/968983002/diff/1/chrome/chrome_renderer.gypi File chrome/chrome_renderer.gypi (right): https://codereview.chromium.org/968983002/diff/1/chrome/chrome_renderer.gypi#newcode72 chrome/chrome_renderer.gypi:72: 'renderer/worker_content_settings_proxy.h', shouldn't this file be ...
5 years, 9 months ago (2015-03-03 13:41:23 UTC) #3
mlamouri (slow - plz ping)
https://codereview.chromium.org/968983002/diff/1/chrome/chrome_renderer.gypi File chrome/chrome_renderer.gypi (right): https://codereview.chromium.org/968983002/diff/1/chrome/chrome_renderer.gypi#newcode72 chrome/chrome_renderer.gypi:72: 'renderer/worker_content_settings_proxy.h', On 2015/03/03 at 13:41:23, jochen (traveling) wrote: > ...
5 years, 9 months ago (2015-03-03 15:03:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968983002/20001
5 years, 9 months ago (2015-03-09 10:14:05 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/50105)
5 years, 9 months ago (2015-03-09 10:43:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968983002/20001
5 years, 9 months ago (2015-03-09 14:05:25 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-09 16:16:53 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 16:17:19 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a5b2945517b18dd86a56fbd922fd8a9ce829f5fc
Cr-Commit-Position: refs/heads/master@{#319647}

Powered by Google App Engine
This is Rietveld 408576698