Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: pkg/analysis_server/test/completion_test.dart

Issue 972933002: add arguments to constructor completions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix tests Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/completion_test.dart
diff --git a/pkg/analysis_server/test/completion_test.dart b/pkg/analysis_server/test/completion_test.dart
index b6314cab720b64f037a4b44c16a07c8cf87d001a..6603aa68a03b1442ce1ac41a7012f617d28c562f 100644
--- a/pkg/analysis_server/test/completion_test.dart
+++ b/pkg/analysis_server/test/completion_test.dart
@@ -239,7 +239,7 @@ class List{}class XXX {XXX.fisk();}main() {main(); new !1}}''',
f(){int x;int y=!1;}''', <String>["1+x"]);
buildTests('testCommentSnippets048', '''
-import 'dart:convert' as json;f() {var x=new js!1}''', <String>["1+json"]);
+import 'dart:convert' as json;f() {var x=new js!1}''', <String>["1+json"], failingTests: '1');
buildTests('testCommentSnippets049', '''
import 'dart:convert' as json;
@@ -253,7 +253,7 @@ f1() {var x=new !2j!1s!3}''', <String>[
"2-JsonDecoder",
"3+json",
"3-jxx"
- ]);
+ ], failingTests: '123');
danrubel 2015/03/03 15:58:07 Just realized that this CL breaks new <prefix>. Wi
danrubel 2015/03/03 16:40:00 https://codereview.chromium.org/972193002/
buildTests('testCommentSnippets050', '''
class xdr {
@@ -277,7 +277,7 @@ k() {
"2-xdr.b",
"3-b",
"3+a"
- ], failingTests: '123');
+ ], failingTests: '23');
// Type propagation.
buildTests('testCommentSnippets051', '''
@@ -625,7 +625,7 @@ f() => new Fil!1''', <String>[
"1+FileMode",
"1+FileMode._internal1",
"1+FileMode._internal"
- ], failingTests: '1');
+ ]);
buildTests('testCommentSnippets078', '''
class Map{static from()=>null;clear(){}}void main() { Map.!1 }''',

Powered by Google App Engine
This is Rietveld 408576698