Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 972863002: Revert of Refactoring: de-couple Extensions from "script injection System" [render side]:2 (Closed)

Created:
5 years, 9 months ago by cpu_(ooo_6.6-7.5)
Modified:
5 years, 9 months ago
Reviewers:
Fady Samuel, Devlin, Xi Han
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@decouple_brower_isolated_world_1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactoring: de-couple Extensions from "script injection System" [render side]:2 (patchset #8 id:350001 of https://codereview.chromium.org/906493004/) Reason for revert: broke the extension tests: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/10543 Original issue's description: > This CL adds routing info for content scripts from <webview>. > > To support dynamically added/removed content scripts in <webview>, we store > these content scripts in the same shared memory where user scripts from > declarative content API are stored, but the decision for injection will > be made in the render once the url pattern is matched. Since render doesn't > need to send IPCs to ask a decision from browser, it makes a precise time > injection possible. > > Special to <webview>, once the content scripts are updated (added/removed), > browser will only notify the render process of the given <webview>, rather than > all of the renders (which is the case for user scripts). > > BUG=437566 > > Committed: https://crrev.com/f853287c95cf818d0b5b02d7f4a6588761096d1c > Cr-Commit-Position: refs/heads/master@{#318774} TBR=rdevlin.cronin@chromium.org,fsamuel@chromium.org,hanxi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=437566 Committed: https://crrev.com/9244b35bbc6b0907e70ca0e62d7ac063d7ef86e9 Cr-Commit-Position: refs/heads/master@{#318810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -99 lines) Patch
M extensions/browser/user_script_loader.cc View 1 chunk +5 lines, -18 lines 0 comments Download
M extensions/common/user_script.h View 5 chunks +0 lines, -37 lines 0 comments Download
M extensions/common/user_script.cc View 4 chunks +0 lines, -22 lines 0 comments Download
M extensions/renderer/extension_injection_host.cc View 1 chunk +4 lines, -9 lines 0 comments Download
M extensions/renderer/user_script_injector.cc View 2 chunks +6 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cpu_(ooo_6.6-7.5)
Created Revert of Refactoring: de-couple Extensions from "script injection System" [render side]:2
5 years, 9 months ago (2015-03-03 00:48:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/972863002/1
5 years, 9 months ago (2015-03-03 00:49:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 00:50:49 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 00:51:40 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9244b35bbc6b0907e70ca0e62d7ac063d7ef86e9
Cr-Commit-Position: refs/heads/master@{#318810}

Powered by Google App Engine
This is Rietveld 408576698